Comments (7)
Cool, I actually don't have access to the HipChat Beta yet. :/
CC @terinjokes who generously supplied the first pull request dealing with it. Perhaps he can help you out?
from hipchatter.
@hawmps Out of curiosity, did you upload just the private key + cert, or did you also upload the intermediate chain from your issuer? I suspect the former, which is why you're not getting a valid chain back. Does the official HipChat clients not give you similar errors? (Our instance has a valid chain)
@charltoons As for the addressing the feature request, needle supports the node standard rejectUnauthorized
option, which can be set to false
. If the user sets a custom endpoint, you may be interested in allowing the user to set this. I, personally, would be a bit hesitant about allowing it for the default https://api.hipchat.com/v2/
endpoint.
from hipchatter.
@terinjokes Awesome. Thanks for the advice, I'll look into that.
from hipchatter.
- I don't get any errors from clients
- I think the problem is not on the hipchat side, its that the ca option for https uses just the mozilla list. Becuase we have our own internal root CA, node js does not trust the certificate on hipchat.
- Rather than disable
rejectUnauthorised
, hipchatter should allow an option forca
to be passed in. I don't actually know what the correct option should be or where the keystore should be located. (EG can node read from window certificate store?)
from hipchatter.
@hawmps Node expects an array of certificates to use the certificate store, it won't use the Windows store by default, and you'll have to figure out how to query that yourself.
from hipchatter.
Thanks @terinjokes
@charltoons Do you think that rejectUnauthorized
be left alone, and instead allow the ca
option to be passed through to needle? The user can then supply their own argument, rather than building that functionality into hipchatter. It's such an edgecase - a windows enterprise shop that uses their own RootCA, hipchat and nodejs :)
from hipchatter.
@hawmps I'm not sure right now. I'm on a mac without access to HipChat hosted right now, so it might take me a while to do some research into this.
from hipchatter.
Related Issues (14)
- Add emoticons HOT 5
- HipChat status api endpoint? HOT 1
- Update NPM HOT 2
- Update NPM HOT 1
- Connect to a room? HOT 2
- Invalid OAuth session HOT 4
- When getting rooms, list is truncated at 100. HOT 1
- Upgrade needle dependency HOT 3
- room_exists returns error instead of false when room doesn't exist HOT 1
- Promise HOT 1
- add existing users to room ? HOT 2
- Keeps posting cat photos to my rooms HOT 2
- Can't set proxy.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hipchatter.