Comments (2)
Sure. You can just remove this bit:
${transparent ? '' : 'invert'}
That is a ternary operator that is adding the invert
class if the transparent
variable is true. If you never want the invert
class, you can just remove that bit. If you want it to always be inverted, you can replace it with just invert
. The ${...}
bit is just a way of putting some JS code in the middle of the string.
I'll close this issue for now. Thanks for the feedback and good luck with your store!
from commercejs-nextjs-demo-store.
Hey. Thanks for the answer @ScopeyNZ . Few more things. Why are anchor tags put inside next link? I've been trying to google it but can't find anything of value. Why not only the Link tag when navigating inside the app? Why the double href?
for example: components\common\Header.js
<Link href="/collection"> <a href="/collection" className="mr-4 font-color-black">Shop</a> </Link>
<Link href="/about"> <a href="/about" className="mr-4 font-color-black"> About </a> </Link>
I would also like to ask about the eslint warning for target:"_blank"
This occurs in components\common\Footer.js
and pages\about.js
<a href="https://commercejs.com/company/about" className="mb-3 d-block font-color-medium" target="_blank" > About </a>
Is this something you should fix or how is this warning to be considered?
There is also an accessibility related eslint warning about the anchor tag in components\homepage\CategoryBanner.js
This doesn't worry me so much, but I wanted to point it out for you just in case you need to do something about it.
Should I open these things as a new issue or is this comment enough?
from commercejs-nextjs-demo-store.
Related Issues (20)
- Server Error ReferenceError: window is not defined HOT 1
- Error while choosing Countries on checkout HOT 1
- Clean up meta tags
- React warnings for using `value` attribute
- React warning for expected <a> tag in <Link> component
- React warning for using deprecated lifecycle hooks in Lottie component
- TypeError: Cannot read properties of undefined (reading 'map') HOT 5
- Products dont show on collection js page HOT 1
- Use category image for feature image and get rid of collections lib
- Update to latest API and update code accordingly
- Update README
- 404 Seed (HELP)
- seed error 404. using npm not yarn HOT 4
- SendGrid integration - Error 500
- Categories images not loading HOT 1
- Product Image Gallery Carousel in Mobile View
- Server mismatch warning on landing page
- Paypal intergration...
- open dashboard.chec.io with 525
- How to remove customer detail & shipping
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from commercejs-nextjs-demo-store.