[FEED] Only register agent if host was created on the server or agent was installed about ansible-collection-checkmk.general HOT 4 CLOSED

I began working on this in #579 and I realized that its a quite complex change regarding the variable checks to introduce for the agent collection.

The best option for me to achive what I want would be to only run this collection when there is no agent installed on the host yet.

This would reduce the amount of times this collections is run dramatically in my setup and would not need any change in the agent collection at all.

Thanks for caring @robin-checkmk and pointing me into the right KISS direction.

from ansible-collection-checkmk.general.

Okay, here is the solution for my problem:

############################################################
# Execute CheckMK Agent Collection & install custom checks #
############################################################

- name: Run checkmk agent role
  hosts: misoft
  tasks:
    - name: Check if CMK agent is installed
      ansible.builtin.shell: dpkg-query -l | grep -q 'check-mk-agent'
      register: cmk_agent_check
      ignore_errors: true
      changed_when: false

    - name: Set fact based on the agent installation state
      ansible.builtin.set_fact:
        cmk_agent_installed: "{{ cmk_agent_check.rc == 0 }}"

    - name: Include custom checks role
      ansible.builtin.include_role:
        name: misoft-role-custom-checkmk-checks

    - name: Include checkmk agent role
      ansible.builtin.include_role:
        name: checkmk.general.agent
      when: not cmk_agent_installed

Yes I achived it in 30 minutes. No idea why I wanted to do this on a much more complex way...

from ansible-collection-checkmk.general.

Hi @peterge1998, maybe I missed it, but you did not actually explain, what you propose to change, correct?
So I would ask you to either update your description or make it a pull request, so we can discuss the proposal properly.
Thanks!

from ansible-collection-checkmk.general.

Hi @peterge1998, maybe I missed it, but you did not actually explain, what you propose to change, correct? So I would ask you to either update your description or make it a pull request, so we can discuss the proposal properly. Thanks!

I created #579, which should implement the behaviour I suggested in my last comment.

But I wonder how I can test my changes, it isnt run by my playbook after copying the folder to roles/ in my ansible dir and defining the folder name in a roles task...

from ansible-collection-checkmk.general.