Giter VIP home page Giter VIP logo

Comments (5)

jamescott avatar jamescott commented on August 26, 2024

OK, candidate #1 for publication: http://docs.opscode.com/dsl_recipe_helper_windows_platform.html

from chef-web-docs-2016.

juliandunn avatar juliandunn commented on August 26, 2024

Thanks James. Looking good overall; a couple of things:

  • I found the intro graf a little wordy. Maybe something like this: "The Recipe DSL provides support for determining the specific platform version in a Microsoft Windows environment by using a utility method inside the Chef::ReservedNames::Win32::Version class" ?
  • Some code errors in the third code block: Ruby uses "elsif" not "elseif", and also the brackets around each conditional are unnecessary, i.e. if windows_version.handler_name? is sufficient)
  • marketing_name doesn't have a question mark on the end of it, since it just returns a string. (In Ruby, methods that return booleans have a '?' by convention; otherwise they don't.) It also doesn't really mean the Microsoft marketing name, so it won't return "Blue" for Windows 8.1; it'll return "Windows 8.1".
  • You can mention that the example installs Powershell 2.0 on systems that don't have it, and it's a publicly-available cookbook at https://ckbk.it/ms_dotnet2 if people want to refer to it.

from chef-web-docs-2016.

jamescott avatar jamescott commented on August 26, 2024

... and updated!

from chef-web-docs-2016.

juliandunn avatar juliandunn commented on August 26, 2024

Cool, thanks James! Couple last things...

  • marketing_name doesn't "test for" the marketing name, it just displays it.
  • The output on the last line of the document is garbled.

Other than that it's great. :shipit:

from chef-web-docs-2016.

jamescott avatar jamescott commented on August 26, 2024

All fixed, hooked into main docs, open source, enterprise builds.

from chef-web-docs-2016.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.