Giter VIP home page Giter VIP logo

Comments (4)

Lonami avatar Lonami commented on June 14, 2024

I guess we're technically building "an end-product" and not a library, even if the end-product is a library (for another language). Given it makes sense as per the book on Cargo.toml vs Cargo.lock and it's useful to do, we probably should commit the file.

from cryptg.

K900 avatar K900 commented on June 14, 2024

Yeah, "no Cargo.lock for libraries" thing is mostly there for the kind of libraries that you'd include in another project, i.e. something that does not produce artifacts by itself. In this case, there is an artifact, namely the Python extension, so I'd say a Cargo.lock makes sense.

from cryptg.

Lonami avatar Lonami commented on June 14, 2024

Do you need a new version to be published to PyPi, or is this okay?

from cryptg.

K900 avatar K900 commented on June 14, 2024

A new version would definitely be preferable, but I'm not really in a hurry, if you've got other changes you want to bundle with that.

from cryptg.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.