Comments (4)
I guess we're technically building "an end-product" and not a library, even if the end-product is a library (for another language). Given it makes sense as per the book on Cargo.toml vs Cargo.lock and it's useful to do, we probably should commit the file.
from cryptg.
Yeah, "no Cargo.lock for libraries" thing is mostly there for the kind of libraries that you'd include in another project, i.e. something that does not produce artifacts by itself. In this case, there is an artifact, namely the Python extension, so I'd say a Cargo.lock makes sense.
from cryptg.
Do you need a new version to be published to PyPi, or is this okay?
from cryptg.
A new version would definitely be preferable, but I'm not really in a hurry, if you've got other changes you want to bundle with that.
from cryptg.
Related Issues (20)
- cryptg make bytes mutable HOT 1
- Add support to release aarch64 wheels HOT 4
- cant build package HOT 6
- Cannot build from this repo even with all requirements satisfied
- Add wheels for python 3.10 HOT 1
- Master branch not being installed HOT 3
- Nodejs module HOT 6
- Ability to disable pushing to PyPi on the manually triggered workflow
- calculate_2fa HOT 2
- Support for Python 3.11 HOT 2
- Building a clean cryptg HOT 1
- Python 3.12 HOT 3
- Huge docker image size HOT 8
- bump grammers for fix factorization issue HOT 3
- allow threads HOT 2
- Android build
- Unable to install on Termux and Linux Deploy HOT 11
- Segmentation fault during install HOT 1
- Please provide source archive for the post2 release, and not only pre-compiled binaries HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cryptg.