list_route isn't working using the ExtendedSimpleRouter. about drf-extensions HOT 10 CLOSED

Hi @Matt3o12

As i understood, list_route and detail_route behaves exactly as drf-extensions collection level controllers:

...
from rest_framework_extensions.decorators import action
...

class UserViewSet(viewsets.ModelViewSet):
    queryset = User.objects.all()
    serializer_class = UserSerializer

    @action(is_for_list=True)  # equals @list_route()
    def confirm_email(self, request, pk=None):
        return Response(['email confirmed'])

    @action()  # equals @detail_route()
    def set_password(self, request, pk=None):
        return Response(['password changed'])

from drf-extensions.

#31 created ticket for documentation

from drf-extensions.

Not quite.
list_route and detail_route let you decided one or more HTTP methods. That means you can allow PUT and POST requests to be handled within the same method.
For example:

class UserViewSet(viewsets.ModelViewSet):
    queryset = User.objects.all()
    serializer_class = UserSerializer

    @action(is_for_list=True)  # equals @list_route(): pk will never be given.
    def confirm_email(self, request, pk=None):
        return Response(['email confirmed'])

    @action()  # equals @detail_route(): pk will always be given.
    def set_password(self, request, pk=None):
        return Response(['password changed'])

       @detail_route(methods=["DELETE"])
            def delete_something():
            return Response("Something deleted")

       @detail_route(methods=["POST", "PUT"])
            def update_something():
            return Response("Something has been updated.”)

Furthermore, the @list_route/detail_rout decorator’s syntax is much more clearer and @action and @link has been marked for pending deprecation.
What they don’t support is an endpoint (e.g. “set-password” instead of “set_password”).

On Sep 5, 2014, at 8:23 AM, Gennady Chibisov [email protected] wrote:

Hi @Matt3o12 https://github.com/Matt3o12
As i understood, list_route and detail_route behaves exactly as drf-extensions collection level controllers http://chibisov.github.io/drf-extensions/docs/#collection-level-controllers:

...
from rest_framework_extensions.decorators import action
...

class UserViewSet(viewsets.ModelViewSet):
queryset = User.objects.all()
serializer_class = UserSerializer

@action(is_for_list=True)  # equals @list_route()
def confirm_email(self, request, pk=None):
    return Response(['email confirmed'])

@action()  # equals @detail_route()
def set_password(self, request, pk=None):
    return Response(['password changed'])

—
Reply to this email directly or view it on GitHub #30 (comment).

from drf-extensions.

list_route and detail_route let you decided one or more HTTP methods

It's always was possible with @action decorator https://github.com/chibisov/drf-extensions/blob/master/rest_framework_extensions/decorators.py#L17

from drf-extensions.

Thanks, I didn’t know that.
Still, I think the syntax is much more clearer and the action decorator will soon be deprecated.

On Sep 5, 2014, at 3:20 PM, Gennady Chibisov [email protected] wrote:

list_route and detail_route let you decided one or more HTTP methods

It's always was possible with @action decorator https://github.com/chibisov/drf-extensions/blob/master/rest_framework_extensions/decorators.py#L17 https://github.com/chibisov/drf-extensions/blob/master/rest_framework_extensions/decorators.py#L17
—
Reply to this email directly or view it on GitHub #30 (comment).

from drf-extensions.

Feel free to make a pull request ;)

from drf-extensions.

I'm seeing this issue also with the ExtendedDefaultRouter using DRF 2.4.4.

from drf-extensions.

In DRF 2.4.4 neither @link(is_for_list=True) nor @action(is_for_list=True) work properly. Any advance on this issue?

Thanks!

Update. Seems that DRF 2.4.4 already has a @list_route() decorator

Update. Moved to another issue #54

from drf-extensions.

Please, don't use collection level controllers and controller endpoint name with DRF => 2.4. These features are hard to maintain because of new extra link and actions

If you want to use nesting facilities you should mixin NestedRouterMixin into your router.

Be careful. ExtendedDefaultRouter and ExtendedSimpleRouter includes deprecated features and can't be used with DRF > 2.4

If you steel have problems, reopen this issue.

from drf-extensions.

This issue still existing as I say in #91.

from drf-extensions.