Issue when change dynamically defaultValueLeftKnob and defaultValueRightKnob about rangeuislider HOT 7 CLOSED

Hi @TofPlay ,

thanks (again for your feedback). I will investigate as soon as possible the problem.

PS remember to support my work by ⭐️ starring ⭐️ my repository

from rangeuislider.

Hi @TofPlay ,

I opened a MR with the fix. Can you check/test it and provide some feedback if it works as expected?
I already added some UI/integration tests but I want also your approval.
In any case I will eventually merge in the next days.

Thanks,
Fabrizio.

from rangeuislider.

Hi @chicio,

Fix defaultValueRightKnob not defaultValueLeftKnob because isValidForLeftKnob method return false

from rangeuislider.

@TofPlay are you sure you're setting a valid value for the left knob with respect to the scale?? Because if you look at the demo app inside RangeUISlider you can find a new screen where I'm testing the fix and it works for both knob (see video below).

Remember also that you have to set the defaultValueRightKnob not defaultValueLeftKnob AFTER you set new scale (because the checks contained in the isValid...Knob are done using the scale values). Have a look at the new demo controller ChangeKnobsProgrammaticViewController to see a usage example.
If it doesn't work, can you share more details about how are you using RangeUISlider? Let me know if the information above solves your problems.

from rangeuislider.

@TofPlay any news? I tested a lot the feature again it seems fine to me. I'm going to merge in a between today and tomorrow. Thanks.

from rangeuislider.

@chicio sorry I'm busy with other higher priority tasks. I don't have time to really test. For the moment your component has been removed from the project. We will look at it again when we resume the functionality that uses it.

from rangeuislider.

Ok @TofPlay no problem. So I will merge it and release a new version (that you can test later). Thank you @TofPlay

from rangeuislider.