Add explicit proxy support for godotenv about godotenv HOT 3 OPEN

Turns out to be a local network environment issue. Closed.

from godotenv.

Turns out to be a local network environment issue. Closed.

More specificly speaking, the DNS of raw.githubusercontent.com is polluted and it will point to localhost. By default the HttpClient.cs uses IE proxy settings, but the proxy setting will bypass localhost. In that case, we have to declare the proxy explicitly when instanciating HttpClient's creation to solve this problem.
Now since the DNS Pollution is not my personal scienario but happens in the whole Mainland China, I think it's valuable to add proxy support for godotenv, hence reopening this issue.

from godotenv.

Now after adding the explicit proxy support, the WebRequestGetAsync() function in NetworkClient well looks like this:

public async Task<HttpResponseMessage> WebRequestGetAsync(string url, string? proxyUrl = null) {
  var proxy = string.IsNullOrEmpty(proxyUrl) ? WebRequest.GetSystemWebProxy() : new WebProxy(proxyUrl);
  var factory = new ServiceCollection()
    .AddHttpClient(Options.DefaultName)
    .ConfigurePrimaryHttpMessageHandler(() => new HttpClientHandler { Proxy = proxy })
    .Services
    .BuildServiceProvider()
    .GetService<IHttpClientFactory>();

  var client = factory.CreateClient();

  return await client.GetAsync(url);
}

Now we can see that there might be potential performance issue, since we cached the http client in the current version, but create a factory each time the function is executed. So what is the real situation?

I have used BenchmarkDotNet to get the same 3 pages in 3 ways: no cache, cache the factory, cache the client, and the result looks like that:

Need to mention that this is the result of the second time, the first time I run this test, the mean time of TestCacheClient goes to 600ms.

from godotenv.