Giter VIP home page Giter VIP logo

Comments (3)

davinkevin avatar davinkevin commented on June 1, 2024

I think the problem was also at the line 187 ( https://github.com/chieffancypants/angular-hotkeys/blob/master/src/hotkeys.js#L187 ) because you set the 4th parameter to false, but it's the 5th parameter for the persistent value (https://github.com/chieffancypants/angular-hotkeys/blob/master/src/hotkeys.js#L265)

Like I said, I let you see if there are some other side-effect to this change.

from angular-hotkeys.

pavolgal avatar pavolgal commented on June 1, 2024

I already reported this one: #36
anyway good catch with line 187

from angular-hotkeys.

chieffancypants avatar chieffancypants commented on June 1, 2024

Thanks for the help, and apologies for the delay. This bug never manifested itself for me as I was never using the allowIn or action parameters, and they were both pull requests from others. As a result, it would be helpful if you could double check and ensure this fixes your problems.

from angular-hotkeys.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.