Broken tests in html-macro 0.7.0 and 0.7.1 about percy HOT 4 OPEN

https://github.com/chinedufn/percy/blob/2aed65476bc4d4660c0eb2fe6c733ce96bf6aee7/README.md#stable-rust

Aah, that explains it! I previously used nightly, but migrated to stable recently. The tests pass on nightly (except for one test that does assertions with regards to error message output.)

One approach would be to add a nightly feature flag to html-macro that controls whether or not unquoted text is supported. So that people can't accidentally use unquoted text on stable.

That would be nice. Or a unquoted-text feature that throws a compile-time error if used on a non-nightly Rust version.

from percy.

cargo -V?
I'm trying to see if you're on stable or nightly.

Right now text works slightly differently on stable vs. nightly.

https://github.com/chinedufn/percy/blob/2aed65476bc4d4660c0eb2fe6c733ce96bf6aee7/README.md#stable-rust

One approach would be to add a nightly feature flag to html-macro that controls whether or not unquoted text is supported. So that people can't accidentally use unquoted text on stable.

from percy.

The quoting workaround is a bit awkward due to double curly braces when using top-level text:

html! { { "Hello World" } },

However, I guess we'll have to live with this limitation for now.

from percy.

There shouldn't be a fundamental reason that we couldn't support html!{ "Hello World" }, would probably just require some tweaks to the parsing logic.

I'm also realizing that we shouldn't need a feature flag.

If you aren't on nightly then Span.line() and Span.column() always return 0, so whenever we encounter unquoted text we can just check the line/column and if they are both zero we create a compile time error that unquoted text only works on nightly.

from percy.