Giter VIP home page Giter VIP logo

Comments (1)

ken-matsui avatar ken-matsui commented on June 15, 2024

@chinthakagodawita
To respond to your question in #282 (review),

If you are hard to keep the dist directory up-to-date, then you just update the dist directory when autoupdate is released.

I think that you previously did the following steps:

$ git commit -am "release v2.0.0"
$ git tag v2.0.0
$ git push origin v2.0.0
$ docker build -t chinthakagodawita/autoupdate:v2.0.0 .
$ docker push chinthakagodawita/autoupdate:v2.0.0

However, I would say new steps are much simpler:

$ yarn build  # Outputs to the `dist`
$ git commit -am "release v2.0.0"
$ git tag v2.0.0
$ git push origin v2.0.0

For users, JS-based actions are faster than Docker-based actions because of no need for the docker pull process. JS-based actions can enforce matching the version and real data because we commit the dist directory. Therefore, JS-based actions can avoid the maintainers' possible mistakes such as a version mismatch between the Docker image and the GitHub Release. Additionally, if you want to invite a new maintainer, you will not need to grant access to DockerHub.

These are advantages of JS-based actions I think, but I ultimately would like to respect your opinion.

from autoupdate.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.