Comments (19)
This should be part of a "Debug" mode option that users can enable/disable on
the
"Settings" page. Instead of a "notification" we may prefer a "toast" when this
debug
option is enabled.
Original comment by [email protected]
on 1 Jun 2010 at 8:12
from omnidroid.
so now there is "toast" in GMailService and SMSService. So should we change it
all to notifications? or just add toast? when smsservice is triggered it shows
some message(something like "smsservice started"), but the final message
whether message was sent or not could be notification.
Original comment by sv767%[email protected]
on 1 Jul 2010 at 5:58
from omnidroid.
Original comment by sv767%[email protected]
on 1 Jul 2010 at 5:58
- Changed state: Started
from omnidroid.
Sorry, I didn't really think this through completely when I posted it.
I think by default a toast should occur for each rule that is applied. Then if
an action deems it appropriate to send it's own toast such as "SMS Sent
Successfully" that fall on the Action object to perform that. This issue is
about implementing the former.
In addition I think it would be of benefit if we could have a "Send
Notification on Rule" option in the Settings activity that instead of using a
Toast it sends a Notification about that Rule being applied.
I think rules should default to Toasts to avoid unwanted notification clutter,
but users should be able to toggle it in the event that they want to easily see
that rules are being applied without having to sift through the logs or
actively monitoring their screen.
Thoughts?
Original comment by [email protected]
on 1 Jul 2010 at 2:11
from omnidroid.
Original comment by [email protected]
on 1 Jul 2010 at 2:15
from omnidroid.
yeah we could have notification on/off in context menu(along with delete,
delete all, enable/disable all, edit) in saved rules activity. but still think
it should be enabled by default. you don't want users not being aware of that
their phone is on silent and blaming omnidroid for missed calls. or we could
have dialog box after you save a rule.
Original comment by sv767%[email protected]
on 1 Jul 2010 at 3:11
from omnidroid.
Defaulting to on for notifications is fine with me as long as we have a way to
turn it off.
Just to clarify, the options that apply to all rules (enable all, disable all,
delete all, toggle notify on/off) should be on the options menu, while the item
specific options (delete, edit, view, etc.) should be on context menus.
Original comment by [email protected]
on 2 Jul 2010 at 3:31
from omnidroid.
I don't like idea of having both.
Original comment by [email protected]
on 2 Jul 2010 at 5:40
from omnidroid.
You don't like having both an OptionsMenu and a ContextMenu or a both
Notifications and Toasts?
Original comment by [email protected]
on 2 Jul 2010 at 10:03
from omnidroid.
the menus. but this should be discussed somewhere else, we should open new
issue about improving saved rules activity.
Original comment by sv767%[email protected]
on 2 Jul 2010 at 10:29
from omnidroid.
Agreed. For reference, Issue111 and Issue66 are about Saved Rules Activity UI
changes.
Original comment by [email protected]
on 6 Jul 2010 at 1:21
from omnidroid.
http://codereview.appspot.com/1726050/show
Original comment by sv767%[email protected]
on 9 Jul 2010 at 7:03
from omnidroid.
committed r807
Original comment by sv767%[email protected]
on 13 Jul 2010 at 5:00
- Changed state: Fixed
from omnidroid.
I just realized that this change looks like it only affects OmniActionServices.
I would think that the original desire would have been to have this applied
during HandlerService processing or ActionExecutor instead of in the specific
Action code. That would allow these notification on all actions as opposed to
limited to implementation by OmniActionServices.
Original comment by [email protected]
on 20 Jul 2010 at 1:33
- Changed state: New
from omnidroid.
why only OmniActionServices?
but you're right, I will consider moving that code to ResultProcessor after i'm
done with it, and also using UtilUI showNotification, but right now we couldn't
have it in ActionExecuter because notification message depends on whether
actions was successfully executed or not.
Original comment by sv767%[email protected]
on 20 Jul 2010 at 2:00
from omnidroid.
Oh I see yes you're right it is included in the other actions as well. I was
just looking at that specific case. But yeah, it should be moved into a more
general location so 3rd party actions will be affected as well. The
ResultProcessor... that's part Issue92 that you're working on? That seems like
the perfect place for it. Looking forward to it! I'll re-mark this as Started
and add blocked on 92. Thanks!
Original comment by [email protected]
on 20 Jul 2010 at 2:12
- Changed state: Started
from omnidroid.
I'm thinking notifications about failure shouldn't be sent until action is
removed from failedactions table. otherwise we would get several notifications
for one action.
thoughts?
Original comment by sv767%[email protected]
on 28 Jul 2010 at 11:35
from omnidroid.
I agree
Original comment by [email protected]
on 28 Jul 2010 at 11:45
from omnidroid.
r839
Original comment by sv767%[email protected]
on 30 Jul 2010 at 4:09
- Changed state: Fixed
from omnidroid.
Related Issues (20)
- Event Handler Limit Crash HOT 1
- Events not executing until lock/unlock performed HOT 12
- no market access HOT 2
- Adopt Guice
- Filter, between pre-midnight and post-midnight HOT 1
- contact groups/aliases for recipient/blacklists HOT 3
- decide whether to perform actions smartly
- An action to Enable/disable actions HOT 1
- Crash when using "Time is day of week" filter HOT 2
- Sensor data not fully utilized in some cases HOT 6
- Enhancement: Disable Data traffic on low battery HOT 2
- Trigger on Wi-Fi SSID HOT 1
- Performance improvement suggestion
- Slow operation in UI thread HOT 1
- Add phone filter : in contact / not in contact
- Enhancement request: action on enter/leave WiFi or mobile base station HOT 1
- Unlock attempt event
- Phone shut down action
- Feature request: event on wifi network available / unavailable
- wrong orders of longitude and latitude when constructing a new OmniArea object in the LocationMonitor
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from omnidroid.