Giter VIP home page Giter VIP logo

Comments (9)

fczuardi avatar fczuardi commented on May 18, 2024 1

Or some other way to tell bankai to inherit the config of browserify, like ava does for babel config:

"ava" {
  "babel": "inherit"
}

from bankai.

yoshuawuyts avatar yoshuawuyts commented on May 18, 2024

💯 this would be great

from bankai.

marionebl avatar marionebl commented on May 18, 2024

Nice idea! I'm not sure if it is optimal to seize the browserify key, though. Can we achieve the same convenience if we read config from the usual places under a bankai key? We could do this easily with e.g. cosmiconfig

from bankai.

fczuardi avatar fczuardi commented on May 18, 2024

For reference / parity, budo works with the config in the browserify field. If we go with the proposed bankai key, it would still be useful to have it fallback to the browserify key when a bankai specific one is not present.

from bankai.

yoshuawuyts avatar yoshuawuyts commented on May 18, 2024

I think the browserify key makes most sense because:

  1. It works the same as with browserify, meaning there's nothing new to learn
  2. It provides parity with wzrd, budo and beefy, further reducing friction
  3. It's easier to upgrade to bankai from any other tool

The less special we make bankai the better I reckon

from bankai.

marionebl avatar marionebl commented on May 18, 2024

Okay, then as a general rule of thumb browserify => bankai.js holds true.

I assume we want to allow file based config of all bankai features at some point, so that would mean bankai and browserify keys can coexist in certain scenarios.

The precedence chain should be bankai.js > browserify, bankai[format] > format-tool in general, I guess.

from bankai.

yoshuawuyts avatar yoshuawuyts commented on May 18, 2024

yeah, sounds alright. Though I wonder if we'll ever arrive at a point where we need bankai specific config; if we ever reach that point I feel it would be good to take a step back and reflect on what we're doing and if couldn't simplify it hah

from bankai.

bcomnes avatar bcomnes commented on May 18, 2024

Doesn't this already happen? I set up the basic example to demonstrate this I thought? https://github.com/yoshuawuyts/bankai/tree/master/example/basic

from bankai.

yoshuawuyts avatar yoshuawuyts commented on May 18, 2024

I think this should work; if not passing { basedir: __dirname } or something to browserify (js:) in the constructor should probs resolve it - closing for now

from bankai.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.