Giter VIP home page Giter VIP logo

Comments (2)

spilth avatar spilth commented on May 24, 2024

Do you have a preference for how you'd like to specify/determine the format of a song that a user is providing?

A couple of options I can think of:

  1. Check for attributes set in either ChordPro or SongPro style in the source of a songsheet.
    • For example: {t: Losing My Religion } vs @title=Losing My Religion
    • It would probably be good to have a format attribute we manage internally to "cache" the answer of this whenever a Songsheet is created/updated.
  2. Make the user specify which format they are using via a dedicate form field.
    • For example, a select option or radio button selection
    • Requires more user work and potentially something they could get wrong.

from chordbook.

bkeepers avatar bkeepers commented on May 24, 2024

There is currently a very rudimentary heuristic for deciding which parser to use that could be quickly added to, but there are a few caveats:

  1. Both the displaying of songsheets and editing currently assume a ChordSheetJS parser and directly use the returned Song model. So the new parser either needs to be implemented in ChordSheetJS, or some kind of new model is needed that both are convert into.
  2. The editor currently has logic to convert to chordpro on paste. There's nothing in the server-side storage that currently requires chordpro, so it wouldn't be difficult to support other formats as long as they can provide metadata.
  3. The editor has a mode for chordpro with snippets, chord completion, and metadata completion. It'd be nice to have the same features for SongPro.

So that first one is really the biggest lift.

from chordbook.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.