Comments (2)
Do you have a preference for how you'd like to specify/determine the format of a song that a user is providing?
A couple of options I can think of:
- Check for attributes set in either ChordPro or SongPro style in the
source
of asongsheet
.- For example:
{t: Losing My Religion }
vs@title=Losing My Religion
- It would probably be good to have a
format
attribute we manage internally to "cache" the answer of this whenever a Songsheet is created/updated.
- For example:
- Make the user specify which format they are using via a dedicate form field.
- For example, a select option or radio button selection
- Requires more user work and potentially something they could get wrong.
from chordbook.
There is currently a very rudimentary heuristic for deciding which parser to use that could be quickly added to, but there are a few caveats:
- Both the displaying of songsheets and editing currently assume a ChordSheetJS parser and directly use the returned
Song
model. So the new parser either needs to be implemented in ChordSheetJS, or some kind of new model is needed that both are convert into. - The editor currently has logic to convert to chordpro on paste. There's nothing in the server-side storage that currently requires chordpro, so it wouldn't be difficult to support other formats as long as they can provide metadata.
- The editor has a mode for chordpro with snippets, chord completion, and metadata completion. It'd be nice to have the same features for SongPro.
So that first one is really the biggest lift.
from chordbook.
Related Issues (20)
- freeze???
- WakeLock does not work in PWA on iOS
- Address bar does not hide in Safari on iOS
- Show parse errors when editing
- Remove use of `pg_search_scope`
- Duplicate artists when creating songsheet with name mismatch
- Improve frontend testing
- Add toggle for menu HOT 3
- Chordpro linter
- Toggle header, footer, and tab bar visibility on songheet HOT 1
- Save thumnails in ActiveStorage
- More margin/padding on larger screens HOT 1
- Update autocomplete controller to use elasticsearch HOT 1
- Migrate from bigint to uuid primary keys
- Use chordpro metdata for external links
- Update home page HOT 1
- Blank slate for setlists
- Guys im really need a help HOT 1
- Consider storing JWT in service worker
- missing user setting in chrome and chords HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chordbook.