clink + Win10 + cyrillic characters with win console V2 - doesn't work about clink HOT 5 CLOSED

Funny story.

I observed several different strange problems with Unicode input. It took me a combined total of around 7 hours of debugging through low level details of Readline and Clink UTF8 processing for the various problems to finally track down the root cause:

Clink forgot to tell the C runtime that it wanted to use UTF8.

Readline asks the C runtime what locale to use, and the C runtime defaults to using the "minimal ANSI conforming environment for C translation", which is essentially an extended-ASCII pseudo-locale. So Clink was trying to talk UTF8, and Readline was trying to talk pseudo-ASCII.

A one line change seems to fix everything (I'm testing further to confirm). Plus I get to delete a bunch of code that had been unsuccessfully trying to compensate for not having this line:

        // Readline needs to know it should use UTF8.
        setlocale(LC_ALL, ".utf8");

from clink.

@chrisant996 thanks a lot for your efforts, all works fine now

from clink.

Thanks! Yes, I haven't worked on that yet. My intent is to include a fix in the first Beta build, provided a fix doesn't prove too invasive (in which case it might get deferred a little bit).

from clink.

I'm working on it now, but I'm running into a number of issues with the GNU Readline library along the way. This could take a while to get working properly, but it will get there eventually.

from clink.

Fixed by 004c691.
Binaries available here.

from clink.