Greedy parameter matching about rlite HOT 5 CLOSED

I was thinking of doing this in rlite. I wrote this: https://github.com/chrisdavies/cljs-router

Which has this feature via this syntax: users/*name

Aso, there's another bug w/ rlite that cljs-router doesn't have, which (if I remember right) is that rlite won't match this:

// Given these two registrations:
const route = rlite(notFound, {
  'foo/bar/baz': someHandler,
  'foo/:name/bing': someOtherHandler
});

// This won't match route('foo/bar/bing');

So, I will add rlite to my queue and get these in.

from rlite.

Sounds good about the * token. I can confirm that bug:

(require('.')(() => console.log('404'), {
  'foo/bar/baz': () => console.log('1'),
  'foo/:name/bing': () => console.log('2'),
}))('foo/bar/bing');

prints 404.

from rlite.

Fixed the bug and added wildcard support.

There is a drawback to these changes, which is that they now require recursion where the previous version didn't. It also added around 100 bytes to the min/gzipped size. It seems like a worthwhile trade-off, though.

If you're using this on the server-side, though, it's possible for this library to cause a stack-overflow now, given a long, malicious URL. So, routes should be matched in a try/catch in that case.

from rlite.

Thanks! I'm using it purely on client side, so I hope I'm safe :)

from rlite.

Oh, and I think Node.js should not be able to trigger a stack overflow via recursion. There's two limits in place, first is the 80kB maximum HTTP header size:

https://github.com/nodejs/node/blob/master/deps/http_parser/http_parser.h#L64

And secondly, there's v8's maximum call stack limit that depends on stack size, thought tail call optimization might change that:

http://2ality.com/2014/04/call-stack-size.html

from rlite.