links replacing # with h1 due to markdown about cms.js HOT 4 OPEN

Great, it works just find... You may can propose it as pull request ?

from cms.js.

I just noticed the comment in the code

// headers - fix link anchor tag regex

I guess this is a known issue

from cms.js.

EDIT: SCRATCH THAT I THINK I MISUNDERSTOOD HOW THE CODE WORKS WHEN GENERATING HEADERS

I'm no expert on regex, but I tested this out and it works.

// headers - fix link anchor tag regex 
{regex: /(#+)([^\/])(.*)/g, replacement: (text, chars, content) => { 
 var level = chars.length; 
 return '<h' + level + '>' + content.trim() + '</h' + level + '>'; 
}},

It tests that there's no / following the first #

Here's a test case
regexr.com/49sbu

from cms.js.

Hi roskelld,

I'm no expert on regex, but I tested this out and it works.

// headers - fix link anchor tag regex 
{regex: /(#+)([^\/])(.*)/g, replacement: (text, chars, content) => { 
 var level = chars.length; 
 return '<h' + level + '>' + content.trim() + '</h' + level + '>'; 
}},

It tests that there's no / following the first #

This code works in filtering # in url links, however it also breaks the detection of regular headings on page markdown articles.

Here's an alternative regex, that works in both cases:

regex: /(#+)(?!\/)(.*)/g

This one assumes that a # preceding a url is directly followed by a / which makes sense in the cms.js environment (e.g. /#/pages/somearticle)

from cms.js.