Comments (6)
Thanks @nscarcella! I'm personally not very familiar with Typescript or Flow, @TrySound has graciously provided all of the flowtype support for dragtastic. Thanks for transcribing it into TypeScript. As the dragtastic api changes over time, would you like to be notified so you can update the typescript definitions?
from react-dragtastic.
It's always better to keep definitions in source repo so they could easily be updated.
from react-dragtastic.
I guess I'm not familiar with DefinitelyTyped
. Is it a repository of typescript definitions, or just a directory that links to repositories with typescript definitions. I agree that it probably makes sense to maintain them with the source repo so they stay in sync.
from react-dragtastic.
It's a repo with definitions.
from react-dragtastic.
Ah, makes sense. @nscarcella would you be willing to open a pull request into this repo with your definitions included? That way there's a more central place to make sure they stay updated.
from react-dragtastic.
Hi @chrisjpatty, @TrySound is right, adding the types to the core would be the absolute best.
I just made a PR with the necessary changes and I'll be happy to help maintain it in my spare time, just send me a notification.
from react-dragtastic.
Related Issues (11)
- Drag delay of 0 should start the drag on mouse down.
- Setstate needs to test if it's mounted before running HOT 4
- New prop for disabling draggable HOT 1
- Pass `dragState` to `onX` callbacks HOT 2
- isOver impacts all Droppables HOT 2
- Escape to cancel drag HOT 1
- dragState.isOver not defined in Flow types for Droppable renderProp HOT 1
- Nested Droppable
- Mobile support
- Version 3 Master Ticket
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-dragtastic.