Load json file when the input has focus about simple-jekyll-search HOT 15 CLOSED

As you wish. This is totally bad practice.

from simple-jekyll-search.

I think it's useful to have the json file loaded on page load, since it's so small, and the intention is to use the search right away, not to wait and then to search. (probably in the meantime I would have already forgotten what I was looking for)

:)

wdyt?

from simple-jekyll-search.

Well, as you say, if it's small, then you wouldn't have to wait, after you enter the search form. So why penalize every visitor even if they don't intend to search?

Also, the json can become pretty big, so this saves time from the initial page load.

from simple-jekyll-search.

@XhmikosR good point.

I just found https://bevacqua.github.io/horsey/ which actually has implemented what we are looking for.
Maybe we could take a look and take inspiration from there

from simple-jekyll-search.

starting from here I got to horsey: https://www.npmjs.com/package/fuzzysearch

from simple-jekyll-search.

gonna close this for now @XhmikosR

from simple-jekyll-search.

Please reopen this. It's a valid request.

from simple-jekyll-search.

@XhmikosR You can always do something like this, in which you can load the JSON yourself on demand, and then initialise search:

$.getJSON("/search.json", function (data) {
            SimpleJekyllSearch({
                searchInput: document.querySelector('#search-input'),
                resultsContainer: document.querySelector('.post-list'),
                json: data,
                searchResultTemplate: template
            });
        });

I'm using jQuery AJAX to load the JSON in this code, but plain JS will work just as well.

from simple-jekyll-search.

@biocross: I'm aware how I can achieve this myself. My point is, this should be a baked in option, because it improves performance.

from simple-jekyll-search.

@XhmikosR if you want you can do a PR so that we can merge the new option

from simple-jekyll-search.

You know I'd do it, but limited time. The request is valid though.

from simple-jekyll-search.

Was this implemented?

from simple-jekyll-search.

nope, just cleaning up old issues

from simple-jekyll-search.

Well, I'm all for that, but this is a valid request. Just keep it open, it doesn't hurt anyone.

from simple-jekyll-search.

Since it's a request, we would need a PR. The discussion was interesting on this issue, but i don't think this is really a blocking issue.
The search.json file is loaded async, is relatively small, and in my opinion it is fine to close the issue

I archived it since it's been months nobody was "burdened" by this issue.

I am open for future PRs, or even rewrites

from simple-jekyll-search.