Read-only field about sanity-plugin-icon-picker HOT 7 CLOSED

Hi @luizhop I'm glad you like it. This is currently not supported but is something we should definitely add support for. Will implement this feature within the upcoming 2 weeks. Feel free to contribute with this feature :)

from sanity-plugin-icon-picker.

That's great @christopherafbjur.
Sure I would be happy to work on this, let me try find some time over the next weeks.
Thanks!

from sanity-plugin-icon-picker.

Hi @christopherafbjur finally I found some time to work on this.

I am just starting with Sanity, React, Typescript and all this stuff, also this is my first contribution to a repository, so apologies for any bad or misplaced changes, specially the ones below I could notice.

Skipped verification for committing and pushing to repo

I was having issues on SearchResults (type check on the component and props import on the tests) and couldn't figure what was the best way to sort them. As I didn't do any changes on these files, I thought it could be something with my node version (20.9.0) and probably won't give you any issues when reviewing and building.

Formatting changes on src/components/IconPicker.tsx

When trying to sort those issues, I thought running yarn format would help with that, in the end it didn't help and I missed reverting it before committing.

Please feel free to make or suggest any changes, I would happy to work on them or to take any advice.

Thanks again!

from sanity-plugin-icon-picker.

Thank you for your contribution @luizhop and the well described challenges you faced. I will have a look at this and come back with an answer in the upcoming days. Merry X-Mas 🎅🏻

from sanity-plugin-icon-picker.

Merged this #63 just now. Thank you for your contribution @luizhop very nice feature 👍

Will create a patch update and publish to npm so it should be available when you read this :)

from sanity-plugin-icon-picker.

Many thanks for that @christopherafbjur, my pleasure being able to help 🙂

from sanity-plugin-icon-picker.

@christopherafbjur merry Xmas (a bit delayed 🐢) and happy new year 🌟
That's perfect, will be great to have your feedback, whenever suits you best. Thank you!

from sanity-plugin-icon-picker.