Fix for Bulgaria (moving to next Monday, Christmas & Easter) about pgsql_holidays HOT 3 CLOSED

Thank you for the feedback! I'll try to make a fix shortly. I'm also able to review pull requests to patch the package.

from pgsql_holidays.

Since I'm naively porting the code from python, it's hard for me to know if it was implemented correctly upstream. Date shifting wasn't implemented in the python lib for Bulgaria, so thank-you for letting me know that it should be there.

I've made some changes to a new branch of the code ("complex_return_experiment"). I'm looking into a more complex return type so that it would be easier to filter data on parameters that aren't directly knowable from the datestamp. This is partially how I want to address your issue. Could you look at the output below and let me know if it would better suit what you would need?

I'm not fully sure if I should drop the English "(Observed)" tags if I use this format, so I'd be curious about your thoughts on that too.

from pgsql_holidays.

I think that the new return format is excellent and suites both business use and general information cases.

About the English "(Observed)" tags - well, it's good to have of course.
What about declaring something like
OBSERVED constant text := '(компенсация)'; -- Bulgarian
in country functions and then use the constant instead of the literal?

One more thought. Holiday lists and rules are changed every now and then in countries around the world and this may go unnoticed. Maybe local people are the best opportunity for updating.
A more declarative approach could help them do so, something like this HOLIDAY_DEFINITIONS "table" in country functions.

create type holidays.holiday_def as
(
 month_value integer,
 day_value integer,
 description text,
 day_off boolean,
 authority holidays.jurisdictional_authority,
 observation_shift boolean
);

-- declare
HOLIDAY_DEFINITIONS constant holidays.holiday_def[] := array
[
-- MONTH_VALUE DAY_VALUE  DESCRIPTION                     OFF_DAY AUTHORITY   SHIFT
   (JANUARY,           1, 'Нова година',                  true,   'national', true),
   (MARCH,             3, 'Освобождение от османско иго', true,   'national', true),
   (MAY,               1, 'Ден на труда',                 true,   'national', true),
   (MAY,               6, 'Гергьовден',                   true,   'national', true),
   (MAY,              24, 'Ден на писмеността',           true,   'national', true),
   (SEPTEMBER,         6, 'Ден на Съединението',          true,   'national', true),
   (SEPTEMBER,        22, 'Ден на Независимостта',        true,   'national', true),
   (NOVEMBER,          1, 'Ден на народните будители',    false,  'national', false)
];
running_holiday holidays.holiday_def;

-- begin 
foreach running_holiday in array HOLIDAY_DEFINITIONS loop
	-- generic country-independent business logic here 
end loop;

Cheers!

from pgsql_holidays.