Giter VIP home page Giter VIP logo

Comments (10)

markerikson avatar markerikson commented on June 3, 2024 4

Would definitely appreciate it if you could release a 1.1.2 that doesn't include that test file.

from geodesy.

chrisveness avatar chrisveness commented on June 3, 2024 3

Apologies for the delay in addressing this – I'm almost catching up with myself! v1.1.2 npm tarball is now 276KB.

from geodesy.

chrisveness avatar chrisveness commented on June 3, 2024

Thanks for bringing this to my attention.

I don't understand how those test data files could have ended up in the npm bundle. They are not in the git repo, and npm should follow .gitignore rules (which exclude the test data files, inter alia).

I shall have to investigate.

from geodesy.

DenisCarriere avatar DenisCarriere commented on June 3, 2024

Seems like your .gitignore file is missing, that might be why.

from geodesy.

chrisveness avatar chrisveness commented on June 3, 2024

I don't have a build process which generates files which need to be git-ignored, so there is no reason to check in my local .gitignore into the repo. npm publish should still be respecting that .gitignore file, though, just as Git itself does, so should not include the test data files in the npm package just as Git doesn't include them in the repo.

from geodesy.

DenisCarriere avatar DenisCarriere commented on June 3, 2024

I don't have a build process which generates files

npm install is a process that generates files.

npm publish won't be looking at root level .gitignore.

from geodesy.

chrisveness avatar chrisveness commented on June 3, 2024

npm install is a process that generates files

npm install is not part of a build process (it is not specified in package.json "scripts"), and also npm publish explicitly ignores node_modules.

The npm Developer Guide says "If there's no .npmignore file, but there is a .gitignore file, then npm will ignore the stuff matched by the .gitignore file".

from geodesy.

DenisCarriere avatar DenisCarriere commented on June 3, 2024

But you don't have a .gitignore file... so nothing is ignored.

from geodesy.

kachkaev avatar kachkaev commented on June 3, 2024

ping @chrisveness :­-)

from geodesy.

markerikson avatar markerikson commented on June 3, 2024

Great, thanks!

from geodesy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.