Giter VIP home page Giter VIP logo

Comments (4)

chubin avatar chubin commented on May 19, 2024 1

Yes, I'm already working on it. The feature will be released soon.

from rate.sx.

chubin avatar chubin commented on May 19, 2024

@westonal I've added initial support of currencies. There are some things to be completed,
so I don't release the feature (not yet). Could you play with it a little bit, and give me some feedback?

I've added support for ten different (I believe, most important) currencies:
AUD, CAD, CHF, CNY, EUR, GBP, IDR, JPY, KRW, RUB

If you choose one of them, you will get your output in that currency.

How do you choose a currency?

$ curl eur.rate.sx
$ curl gbp.rate.sx
$ curl cad.rate.sx

(it does not matter if you use the upper or the lower case; you can mix them: EUR.rate.sx is ok; CaD.Rate.SX is also ok).

If you use some unknown currency, it silently uses USD. So be careful here (probably, we should print some warning or even error in this case?).

For dollars (USD, AUD, CAD) you have '$' in front of the numbers in the headers (Market Cap: $351,742,820,072). You have to know, what $ is ment here (because you issue the query). I don't know, if it is correct. I suppose yes, in Canada and Australia the $ sign is used for local currencies, right?

Open questions at the moment (things to be implemented):

  • 1h and 24h changes are calculated basing on the current currency rate, what is strictly speaking wrong, but not really critical, because these currencies are not really volatile (this bug will be fixed soon; I just want to warn you) (and this bug is critical if we use cryptocurrencies as the target currency: btc.rate.sx; not implemented yet anyway);
  • for JPY and KRW, BTC price is displayed in scientific notation (1.31391e+6, 1.26863e+7) what is inconsistent.

Could you please test the new feature and give me some feedback?

from rate.sx.

westonal avatar westonal commented on May 19, 2024

For dollars (USD, AUD, CAD) you have '$' in front of the numbers in the headers (Market Cap: $351,742,820,072). You have to know, what $ is ment here (because you issue the query). I don't know, if it is correct. I suppose yes, in Canada and Australia the $ sign is used for local currencies, right?

Yes that's right, elsewhere it clearly says "CAD/AUD/USD", so it's obvious which $ it's refering to.

not really critical, because these currencies are not really volatile

Well, they can shift by a 1 or 2% some days, especially GBP with Brexit!

You might find this service useful to get % change in other currencies: https://apiv2.bitcoinaverage.com/#ticker-data-all

But looking good! Thanks!

from rate.sx.

chubin avatar chubin commented on May 19, 2024

Done

from rate.sx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.