Giter VIP home page Giter VIP logo

Comments (9)

Cimbali avatar Cimbali commented on June 19, 2024 1

Done part one. I'll try to get around to making the popup nicer, and filter the list by the current tab.

I think that makes more sense than current domain, in case some other/sub domain makes a request (through an iframe or whatnot).

from cleanlinks.

alekksander avatar alekksander commented on June 19, 2024 1

„Clear List” doesn't clear it until tabs are switched.

In general it's looking better. if You are asking for suggestions, here is mine to consider:
screenshot_20180726_101059
(sorry for ugly sketch)

from cleanlinks.

Cimbali avatar Cimbali commented on June 19, 2024

You mean when a domain is whitelisted, remove all the items in the list with that domain? Because there shouldn't be new ones any way.

from cleanlinks.

alekksander avatar alekksander commented on June 19, 2024

i've clicked 3 last entries from the screen shot in previous post and what i get is:
clog
as You can see collector.githubapp.com is added three times.

from cleanlinks.

jawz101 avatar jawz101 commented on June 19, 2024

Or at least a clear button on the log. As I browse around it accrues a laundry list of cleaned links. When I have an issue that needs whitelisting I have to sift through a bunch of old sites' links cleaned and it's a bit more confusing when I can't just clear out the log when needed.

But the option to show just the current tab would be better.

from cleanlinks.

Cimbali avatar Cimbali commented on June 19, 2024

Any feedback/suggestions on the current popup's appearance? @alekksander @jawz101

from cleanlinks.

Cimbali avatar Cimbali commented on June 19, 2024

@alekksander @jawz101 Care to try out the looks of the latest commit?

from cleanlinks.

alekksander avatar alekksander commented on June 19, 2024

i don't want to be the one that seems ungrateful and complains all the time, but if i had skills and free time i'd:
→fix it's width (when list is empty it's nice and small, when list contains something it gets too wide. perhaps cut it half?)
→shrink logo a bit, and leave about ⅔ of it's current size
→title and logo missing that 5px margins, that icon buttons has

thank You for Your work so far.

from cleanlinks.

Cimbali avatar Cimbali commented on June 19, 2024

Don't worry about it! I'm happy to get feedback, as I don't have strong opinions on the appearance anyway. Here's another update.

from cleanlinks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.