Comments (16)
Works for me, both with scroll-button click and ctrl + click. even the "switch to tab" option
Can you be more specific? CleanLinks version, Firefox version, platform? Thanks
from cleanlinks.
I can confirm that middle click and control left click both open the link in the current tab, not in a new tab.
Browser: Waterfox 56.2.0 (64-bit)
from cleanlinks.
Interesting. You have outgoing HTTP requests cleaning disabled, is that right?
It appears if you activate it the request gets denied, and on a second click it then works. Both work fine on firefox 60.0.
from cleanlinks.
Turns out we use the openerTabId property which is compatible with ff 57+, to indicate to which tab to return on closing the new tab. We'll probably need to figure out which is the lowest version we want to support and account for that.
from cleanlinks.
Did a bit of testing.
I can still reproduce this using v3.0.3 on clean Firefox 60.0.2 install on OS X 10.11.6. But I have tried on Windows and it works as expected.
from cleanlinks.
Can you maybe open the Console (Ctrl + Alt + Shift + i, it's going to ask for remote debugging confirmation) to check for error messages?
Basically on the toolbox that the shortcut opens, go to the Console tab, purge the history for ease of reading (trash can in the top left corner), and click a link that fails.
There should be an error message from either cleanlink.js, background.js or inject.js which are the 3 CleanLinks scripts involved.
from cleanlinks.
I tried add-on debugging console, but it shows nothing related to Clean Links extension when I Cmd + click on links in Google search results.
from cleanlinks.
Ah, my bad, the error doesn't show because there already is a fallback in case of error. I've added a print, in the debug_print_22 branch.
I don't have a mac to reproduce this, so what would be helpful to debug this issue would be for you to get that branch with the debug print, and report the error.
Here's a step by step guide:
- get the debug_print_22 branch (there is a zip download in the "Clone or download" button)
- extract the zip if you downloaded the addon zipped
- disable your current cleanlinks in your browser
- type
about:debugging#addons
in your firefox address bar - tick "Enable add-on debugging"
- click "Load Temporary Addon"
- select the
manifest.json
file from the source code you just downloaded/extracted
Now just repeat the steps to look at the debugging console while doing Cmd + Click and an error message should appear. You can filter the console by "Logging > Errors" using the buttons in the top row.
from cleanlinks.
I get only this in console when Google search results loaded and nothing else when Cmd + clicking on links.
from cleanlinks.
Alright, well that's a start. Maybe that exception in the background script prevented it from correctly opening a new window later on or something. I fixed it, now let's see if it works.
from cleanlinks.
Now that error has gone and no other appear.
from cleanlinks.
@Cimbali, can you please re-open the issue, if itโs not already fixed?
from cleanlinks.
@nerone My main problem with this issue is just that I can't reproduce it. It is fixed for Waterfox and FF < 57 though, just not your setup (maybe os x is the troublemaker?)
from cleanlinks.
this issue also occurs on reddit when clicking on any of those types of links shown in the screenshot
from cleanlinks.
I think this is actually a really simple bug now I look back at it. We recreated the ctrl + click
behaviour manually:
Lines 37 to 38 in dbcdb4f
On macOS the default is to use cmd + click
instead of ctrl + click
. So now we check for both. There should not be too much interference from meta + click
on other OSs, as this is not a meaningful combo usually.
Some testing on macOS still needs to happen, because ctrl + click
should open the context menu, so we maybet accidentally overwrite that behaviour. Ideally I would like not going down the rabbit hole of detecting which OS we are running on to adapt behaviour etc.
from cleanlinks.
I can confirm this now works as expected.
from cleanlinks.
Related Issues (20)
- Clean URLs in youtube description HOT 5
- Clean URL before or after... HOT 1
- Encoded link - query parameter(s) not cleaned HOT 4
- add to link HOT 2
- Export custom rules HOT 2
- Possible to integrate copying clean links into browser's default copy action? HOT 2
- CleanLinks popup is enormous. I have to zoom out every time I open it. HOT 4
- How to prevent cleaning livejournal's "expand thread" links? HOT 1
- Helper for special symbols in parameters HOT 2
- pstmrk.it links evade autoamtic detection
- LiveJournal - redirecting without logging HOT 4
- "Disable for child tabs" quick option request HOT 1
- rapidgator clean
- Bing Result Rewrite HOT 12
- Google search results add some redirect in the sites HOT 1
- Not a bug: uBlock subscription which does something similar HOT 1
- CleanLinks disables open link in a new tab HOT 1
- Start popup scrolled down HOT 1
- Add-On started causing 'The page isnโt redirecting properly' error HOT 1
- [Bug] find_click_target doesn't handle href if null HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cleanlinks.