Giter VIP home page Giter VIP logo

Comments (8)

alekksander avatar alekksander commented on June 16, 2024

false alarm, i can't reproduce anymore. sorry.

from cleanlinks.

alekksander avatar alekksander commented on June 16, 2024

@Cimbali
another whitelist ignored.
go:
https://imgops.com/i.imgur.com/Dr2QZWF.png
and click express on → pixlr [express]

again no matter how many times, the whitelisted item is ignored

from cleanlinks.

Cimbali avatar Cimbali commented on June 16, 2024

AFAICT there is no bug there:

  • Clicking the link cleans it and brings to imgops.com
  • Whitelisting once whitelists apps.pixlr.com.
  • Going back one page and click the link again, correctly brings apps.pixlr.com which then redirects to pixlr.com, with again imgops.com in the URL. Thus CleanLinks cleans this second link and brings to imgops.com again.
  • Whitelisting a second time now whitelists pixlr.com
  • Going back and clicking again, the browser opens the pixlr.com page as expected.

from cleanlinks.

alekksander avatar alekksander commented on June 16, 2024

i end up at http://imgops.com/

from cleanlinks.

Cimbali avatar Cimbali commented on June 16, 2024

Can you check the last items in your whitelist?
If there is pixlr.com and apps.pixlr.com, you should end up at https://pixlr.com/express/?exit=http://imgops.com&image=http%3A%2F%2Fi%2Eimgur%2Ecom%2FDr2QZWF%2Epng?exit=http://imgops.com&image=http%3A%2F%2Fi%2Eimgur%2Ecom%2FDr2QZWF%2Epng

from cleanlinks.

alekksander avatar alekksander commented on June 16, 2024

there is only apps.pixlr.com
but when it redirects me to imgops.com CL has new redirection. if i whitelist it pixlr.com is added. then i manually go back to the
https://imgops.com/i.imgur.com/Dr2QZWF.png
and it works fine on next clicks

so it's not bug after all, but it's confusing. i imagine there is no walk around this for regular user

from cleanlinks.

Cimbali avatar Cimbali commented on June 16, 2024

The problem is this site is built with 2 redirections. We can't detect the second one when we clean the first one, and having a whitelisted site redirect to a non-whitelisted one means the whitelist stops applying then.

So you basically have to repeat the whole process until it works: go to original page, click link, whitelist.

If you can think of a way to improve the experience I'm interested.

from cleanlinks.

alekksander avatar alekksander commented on June 16, 2024

i'm afraid solution is out of my knowledge here, but if i have to use my imagination i'd say CL should analyze link for further redirects before it does the first one, and perhaps list them all with different color (like light yellow, or something else specified in „?”), so when user ends up at imgops.com list shows there was a presumed further redirection that could be whitelisted. it's just an idea, i guess it's additional work for mechanisms with relatively rare application for user.

from cleanlinks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.