GetAll returns all the music even though batchNumber specified about react-native-get-music-files HOT 14 CLOSED

@cinder92
com.facebook.react.bridge.WritableArray.size() returns 1 all the time, adding a separate counter for JsonArray size at com.cinder92.musicfiles.RNReactNativeGetMusicFilesModule.getSongs should solve this issue.

will make a pull request as soon as the docs are finalized.

from react-native-get-music-files.

@eff-society
workaround would be to use RNAndroidAudioStore.getAll :p
as I mentioned earlier, the problem seems to be the return value of com.facebook.react.bridge.WritableArray.size() @ com.cinder92.musicfiles.RNReactNativeGetMusicFilesModule.getSongs.

from react-native-get-music-files.

@renganatha10 how many songs do you have on your device? maybe is a stupid question, but in this way we ca check what is happening, and what are the specs of your device? simulator? real one?

from react-native-get-music-files.

from react-native-get-music-files.

@renganatha10 could you please try to install the module again from this github repo instead of npm, and test again please?

from react-native-get-music-files.

I'm having the same issue, console.log(params.batch.length); shows 5000+. It only shows 1 when I set batchNumber: 1
Also, i'm trying to log the result of getAll but it never gets to the log:

async componentDidMount(): Promise<void> {
    try {
        const tracks: any = await MusicFiles.getAll({
            id: true,
            blured: false,
            artist: true,
            duration: true,
            cover: false,
            title: true,
            batchNumber: 5,
            minimumSongDuration: 10000,
            fields: ['title', 'artist', 'duration'],
        });
        console.log('number of tracks: ', tracks.length);
    } catch (err) {
        console.log('Error while getting music files: ', err);
    }
}

from react-native-get-music-files.

@clems36
Does the logcat show any errors?

from react-native-get-music-files.

@cinder92 I am installing directly from GitHub FYI I am Using Android 8.1

Screen Shot of JS console which returns the result in Batch

Screen Shot of Android Logcat

from react-native-get-music-files.

@Drazail Yes:

I don't understand why i'm getting this error though, why is it trying to save images ?

from react-native-get-music-files.

@clems36 MusicFiles.getAll() extracts meta data directly from the file, saves the cover image and sends the path over the bridge to the JS thread, the other option is to send the image itself which would block the bridge and can cause crashes.

this is currently the only way ( and a very slow one at that) of retrieving thumbnails i can think of as ALBUM_ART constant of MediaStore.Audio.AlbumColumns was deprecated in API level Q.

from react-native-get-music-files.

I'm not sure I understood everything you said but basically do you have a way to avoid this error ?

from react-native-get-music-files.

@clems36

There's a snippet from the example app, its a function which asks for read/write permissions recursively :

requestPermission = async () => {
      try {
        const granted = await PermissionsAndroid.requestMultiple(
          [
            PermissionsAndroid.PERMISSIONS.READ_EXTERNAL_STORAGE,
            PermissionsAndroid.PERMISSIONS.WRITE_EXTERNAL_STORAGE
          ],
          {
            title: "Permission",
            message: "Storage access is requiered",
            buttonPositive: "OK"
          }
        );
        if (granted === PermissionsAndroid.RESULTS.GRANTED) {
          alert("You can use the package");
        } else {
          requestPermission();
        }
      } catch (err) {
        console.warn(err);
      }
    };

This should fix the permission issues.

from react-native-get-music-files.

Experiencing the same issue. Is there a workaround for it yet?

from react-native-get-music-files.

closing this in favor of #108

from react-native-get-music-files.