Giter VIP home page Giter VIP logo

Comments (17)

pavanjoshi914 avatar pavanjoshi914 commented on July 17, 2024 1

Screenshot (37)

@pavanjoshi914 What do you think of this enhancement?
I have changed the hover effect, width of the logo, and some small navbar bugs.
It is a hover effect on home link.!

LGTM!! lets wait for reply from @ShreyaPrasad1209

from blog.

ShreyaPrasad1209 avatar ShreyaPrasad1209 commented on July 17, 2024 1

@vedant-jain03 we can change Home button from red to green to maintain consistency with the theme. Let's wait for @nitin10s's reply.

@nitin10s what do you think?

from blog.

vedant-jain03 avatar vedant-jain03 commented on July 17, 2024 1

oh my bad, I was referring to something else. Here what we could do, is completely remove the home button since clicking on the logo anyway directs home. Other than that, the logo fixes look good to me.

Please go ahead and open PR for the same

Thanks for clearing the doubt nitin .
I will just remove the home button and make hover effects on contact only, and add green theme color to them.
give me thumbs up If I am right. I will just make change and raise PR then.

from blog.

vedant-jain03 avatar vedant-jain03 commented on July 17, 2024

@ShreyaPrasad1209 @pavanjoshi914 is it a valid Issue?

from blog.

pavanjoshi914 avatar pavanjoshi914 commented on July 17, 2024

Navbar size looks appropriate to me. suitable with the theme as the same area is utilized for search and logo. still, you can present your work for an enhanced version of the navbar and we can see what looks more appropriate.

from blog.

vedant-jain03 avatar vedant-jain03 commented on July 17, 2024

Sure @pavanjoshi914 I will give you the sample screenshots within next 3 days and then you can compare which is looking more better.
Thankyou :)

from blog.

vedant-jain03 avatar vedant-jain03 commented on July 17, 2024

Screenshot (37)

@pavanjoshi914 What do you think of this enhancement?
I have changed the hover effect, width of the logo, and some small navbar bugs.
It is a hover effect on home link.!

from blog.

vedant-jain03 avatar vedant-jain03 commented on July 17, 2024

Screenshot (37)
@pavanjoshi914 What do you think of this enhancement?
I have changed the hover effect, width of the logo, and some small navbar bugs.
It is a hover effect on home link.!

LGTM!! lets wait for reply from @ShreyaPrasad1209

Sure

from blog.

vedant-jain03 avatar vedant-jain03 commented on July 17, 2024

@vedant-jain03 we can change Home button from red to green to maintain consistency with the theme. Let's wait for @nitin10s's reply.

@nitin10s what do you think?

Sure I will give green theme color in hover effect

from blog.

vedant-jain03 avatar vedant-jain03 commented on July 17, 2024

@ShreyaPrasad1209 I have done with the edit you have told me to do. Should I raise PR

from blog.

nitin10s avatar nitin10s commented on July 17, 2024

Hey Vedant, that's a nice observation, but why do you want to hide all the nav-links? The nav-links are shown so that the user can take a glance and understand what all we have to offer without clicking anywhere or anything

from blog.

vedant-jain03 avatar vedant-jain03 commented on July 17, 2024

Hey Vedant, that's a nice observation, but why do you want to hide all the nav-links? The nav-links are shown so that the user can take a glance and understand what all we have to offer without clicking anywhere or anything

Actually @nitin10s Their are only 2 navlinks (home and contact), I not hide them, just added hover effect in each as you can see home link with red background.
In additional I have reduced the size of logo to 65%
and also fixes centralization of navbar.

from blog.

nitin10s avatar nitin10s commented on July 17, 2024

What about the nav-links we currently have?

from blog.

vedant-jain03 avatar vedant-jain03 commented on July 17, 2024

What about the nav-links we currently have?

@nitin10s https://blog.circuitverse.org/ in this site I am not able to see nav-links more then home and contact with search and logo. Can you please tell me nitin , where I can see other navlinks?

from blog.

nitin10s avatar nitin10s commented on July 17, 2024

oh my bad, I was referring to something else. Here what we could do, is completely remove the home button since clicking on the logo anyway directs home. Other than that, the logo fixes look good to me.

Please go ahead and open PR for the same

from blog.

nitin10s avatar nitin10s commented on July 17, 2024

One more improvement we need is to change the red colour used to our characteristic green (if you could also fix that issue, in another PR)

from blog.

vedant-jain03 avatar vedant-jain03 commented on July 17, 2024

I have done changes in themes/northendlab-hugo , this is submodule. How can I push my code,?
@pavanjoshi914 @ShreyaPrasad1209 @nitin10s

from blog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.