Giter VIP home page Giter VIP logo

Comments (8)

kbreit avatar kbreit commented on July 24, 2024

@sivel How do I tell the collection to not have the files which shouldn't be there?

from ansible-meraki.

sivel avatar sivel commented on July 24, 2024

In Ansible 2.10 you can use build_ignore in galaxy.yml https://docs.ansible.com/ansible/devel/dev_guide/collections_galaxy_meta.html#collections-galaxy-meta

Otherwise, you may want to consider having a separate clean directory where you build the artifacts, separate of where you do your development. Potentially even building and publishing via CI.

from ansible-meraki.

kbreit avatar kbreit commented on July 24, 2024

@sivel Could you take a look at #149 and let me know if it, at least at a glance, covers everything it should. Here's what I'm seeing when I extract a new tarball.

(venv) temp [2.0/build_ignore●] % tar -xvzf cisco-meraki-1.3.2.tar.gz
x MANIFEST.json
x FILES.json
x plugins/
x plugins/doc_fragments/
x plugins/doc_fragments/__init__.py
x plugins/doc_fragments/meraki.py
x plugins/action/
x plugins/inventory/
x plugins/module_utils/
x plugins/module_utils/network/
x plugins/module_utils/network/meraki/
x plugins/module_utils/network/meraki/__init__.py
x plugins/module_utils/network/meraki/meraki.py
x plugins/filter/
x plugins/modules/
x plugins/modules/meraki_organization.py
x plugins/modules/meraki_config_template.py
x plugins/modules/meraki_device.py
x plugins/modules/meraki_network.py
x plugins/modules/meraki_content_filtering.py
x plugins/modules/meraki_mr_l3_firewall.py
x plugins/modules/meraki_switchport.py
x plugins/modules/meraki_mx_site_to_site_firewall.py
x plugins/modules/meraki_site_to_site_vpn.py
x plugins/modules/meraki_mx_l3_firewall.py
x plugins/modules/meraki_vlan.py
x plugins/modules/meraki_nat.py
x plugins/modules/__init__.py
x plugins/modules/meraki_static_route.py
x plugins/modules/meraki_switch_storm_control.py
x plugins/modules/meraki_switch_stack.py
x plugins/modules/meraki_firewalled_services.py
x plugins/modules/meraki_webhook.py
x plugins/modules/meraki_admin.py
x plugins/modules/meraki_intrusion_prevention.py
x plugins/modules/meraki_management_interface.py
x plugins/modules/meraki_ssid.py
x plugins/modules/meraki_ms_link_aggregation.py
x plugins/modules/meraki_switch_access_list.py
x plugins/modules/meraki_mx_l7_firewall.py
x plugins/modules/meraki_malware.py
x plugins/modules/meraki_mx_uplink.py
x plugins/modules/meraki_syslog.py
x plugins/modules/meraki_snmp.py

from ansible-meraki.

sivel avatar sivel commented on July 24, 2024

That looks good. Thanks for the help. As of now the ansible-2.10.0a3 package contained the full venv referenced before.

I honestly don't know what the expectation is about delivering the tests too, but I'm fine with it this way.

from ansible-meraki.

kbreit avatar kbreit commented on July 24, 2024

@sivel Do I need this as part of master to be picked up by your work?

from ansible-meraki.

sivel avatar sivel commented on July 24, 2024

@kbreit I am not specifically doing anything. It was completely accidental that I ran across this.

Until this is used to build the collection artifact, the Ansible 2.10 release will contain your virtualenv. I am not part of the team that owns that process, but I did make them aware of this.

from ansible-meraki.

kbreit avatar kbreit commented on July 24, 2024

I will release a new 1.3.2 version today to remedy this. Thank you.

from ansible-meraki.

kbreit avatar kbreit commented on July 24, 2024

I released v1.3.2. yesterday and that should have the files removed. If there are files in the package which shouldn't be there, let me know.

from ansible-meraki.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.