code is issues about cstore_fdw HOT 4 CLOSED

Hi @whxfly could you elaborate the issue little bit ? I could not understand it from the comment.

thanks

from cstore_fdw.

the code should ?

for (blockIndex = 0; blockIndex < stripeBlockCount; blockIndex++)
{
columnSkipList[blockIndex].rowCount = 0;
columnSkipList[blockIndex].hasMinMax = false;
columnSkipList[blockIndex].minimumValue = 0;
columnSkipList[blockIndex].maximumValue = 0;
columnSkipList[blockIndex].existsBlockOffset = 0;
columnSkipList[blockIndex].valueBlockOffset = 0;
columnSkipList[blockIndex].existsLength = 0;
columnSkipList[blockIndex].valueLength = 0;
columnSkipList[blockIndex].valueCompressionType = COMPRESSION_NONE;
}

from cstore_fdw.

that code portion is to support alter table add column.
If a user adds a column after a cstore_fdw table is created, metadata for previously added columns do not have any values for the new column. The code path you mention is to say we know nothing, about values of new columns.

from cstore_fdw.

@whxfly hope it answers your question. Is there anything else I can help you with ? otherwise I am going to close the issue.

thanks.

from cstore_fdw.