Docker Image about tindetheus HOT 8 CLOSED

This is a good idea. I haven't kept the docker image up to date, so I should probably look into auto builds as well.

from tindetheus.

So the Docker autobuilds are working again.

I changed the submodule to point to https://github.com/cjekel/pynder.git to deal with not having permission from https://github.com/charliewolf/pynder.git which was previously killing the autobuild process.

I also used COPY instead of git clone.

Thanks for the help!

from tindetheus.

e78510e

from tindetheus.

@VikashKothary I added a dockerfile and tried to setup automatic docker builds, but the automatic builds were failing because Docker can't clone with ssh the submodule because I don't have write permission to the original pynder source. I couldn't figure out a way to get docker to clone the tindetheus without ssh.

Then I abandoned this since I thought that building the image yourself with the dockerfile was easy enough.

from tindetheus.

@cjekel Is there a reason you're cloning the git repository as opposed to just using COPY to move the files across. If it's done by a CI, you can assume all the fine will be identical to the repo.

Also the submodule can be made to use ssh if you want. It just involves updating the url here.

Let me know which you prefer.

from tindetheus.

Let me see if changing that will get the Docker auto builds working
Edit: This was with regards to the sudmodule. Strange it was already using https as I thought ssh was causing the autobuild isssue. Https makes sense here since we don't have write permission to that repo?

from tindetheus.

@VikashKothary Feel free to send a PR for that line in the Dockerfile. Other than this, does everything else seem reasonable?

from tindetheus.

Hi @cjekel, that all sounds good. I'll try and make a PR when I next get some free time. I'll be nice to have the Docker image working again. 👍

from tindetheus.