Giter VIP home page Giter VIP logo

Comments (20)

LordPeter avatar LordPeter commented on May 26, 2024

I'd be willing to help here as said before, but I lack ideas for good "base colours" for the culture groups. Those should be somewhat related to the main nation's colour or something, so green (or maybe black?) for Arabic. Could use suggestions there.
I think they should actually ideally be similar for related groups, so that you can see that e.g. all the Indo-Aryans are somewhat related at a glance (but on a broader level, maybe shades of red, shades of orange & shades of violet).

from ck2plus_rewrite.

schwarherz avatar schwarherz commented on May 26, 2024

I'm inclined to agree, with one caveat: The groups that are unrelated should be dissimilar enough to allow someone who is visually impaired (e.g. colorblind) to be able to easily distinguish them as well.

from ck2plus_rewrite.

LordPeter avatar LordPeter commented on May 26, 2024

Well, colorblind is a whole different level. Can't make a 100% promise there, but you are right we need to take that into account and try to make it as good as possible.

from ck2plus_rewrite.

questionmarkexclamationpoint avatar questionmarkexclamationpoint commented on May 26, 2024

Has this been thought about any more? I would be happy to implement some of this. Some colors I was thinking:

  • Gallo-Roman: Blue
  • Iberian: Yellow or Red (probably red so I can make leonese a little purplish)
  • Occitano-Romance: Also Yellow or red, but the opposite of the above for visibility
    • these colors appear on coats of arms of both Aquitaine and Catalonia
  • Vasconic: Green, the emerald at the center of the Navarrese coat of arms

Some of these are ultimately gonna be guesses or anachronistic, though. If this sounds fine I can go ahead and implement it for the culture groups that have already been set up.

from ck2plus_rewrite.

LordPeter avatar LordPeter commented on May 26, 2024

colour_mix_11_Var_A

from ck2plus_rewrite.

LordPeter avatar LordPeter commented on May 26, 2024

Alright, context: This is a "helper" pic I hand-painted, to help with ensuring that contrast is correct.

from ck2plus_rewrite.

questionmarkexclamationpoint avatar questionmarkexclamationpoint commented on May 26, 2024

How many shades are represented there? Because we can probably just adjust the hue on all those to cover pretty much every culture group.

from ck2plus_rewrite.

LordPeter avatar LordPeter commented on May 26, 2024

Eleven, as that was the largest number of cultures in a single group at that point. Not sure if we exceeded it after the recent addition spree...
But yeah, the idea was to adjust the pic for each group with different shades of the base colour. The difficult thing for me was to produce a 2-dimensional image that had every shade touch every other shade at least once, because contrast is relative.

from ck2plus_rewrite.

LordPeter avatar LordPeter commented on May 26, 2024

Sh*t, we did exceed it. It's 13 now, in Turkic. My own fault for adding Bashkir etc...

from ck2plus_rewrite.

LordPeter avatar LordPeter commented on May 26, 2024

So that pic would have to be redrawn. Getting increasingly complex to keep track of things... but I can give it a try, unless someone else wants to.
Anyway, once we have that, it would help to determine if contrast is good enough between each pair.

from ck2plus_rewrite.

questionmarkexclamationpoint avatar questionmarkexclamationpoint commented on May 26, 2024

I might write a quick script to generate an image with each pair of shades next to one another so we can see that. Does that sound useful? We could pass it a hue as an argument and it could spit out an image showing each color next to each other color, and the 11 (or 13) different possible colors.

from ck2plus_rewrite.

questionmarkexclamationpoint avatar questionmarkexclamationpoint commented on May 26, 2024

If you can provide 13 pairs of saturation and value, I can write that script pretty easily.

from ck2plus_rewrite.

LordPeter avatar LordPeter commented on May 26, 2024

Man... sure, you probably can code something like this. I just could not do it...
So, sure! If you can create such a pic, that would be awesome. I'm hereby delegating this task to you!

What do you mean with providing 13 pairs - as a "test case" for the script to run on or something else?

from ck2plus_rewrite.

questionmarkexclamationpoint avatar questionmarkexclamationpoint commented on May 26, 2024

I ended up using an eyedropper tool to try to figure out how you chose the colors for that image, and I think I got it. Here is an example of what the script can do:
69

0: { 0.27 0.3 0.1 }
1: { 0.338 0.375 0.125 }
2: { 0.405 0.45 0.15 }
3: { 0.473 0.525 0.175 }
4: { 0.54 0.6 0.2 }
5: { 0.608 0.675 0.225 }
6: { 0.675 0.75 0.25 }
7: { 0.707 0.775 0.325 }
8: { 0.74 0.8 0.4 }
9: { 0.773 0.825 0.475 }
10: { 0.805 0.85 0.55 }
11: { 0.838 0.875 0.625 }
12: { 0.87 0.9 0.7 }

from ck2plus_rewrite.

questionmarkexclamationpoint avatar questionmarkexclamationpoint commented on May 26, 2024

I'm going to make a pull request for this in a bit when I clean up the script some, then I'll use it to start generating cultural colors.

from ck2plus_rewrite.

questionmarkexclamationpoint avatar questionmarkexclamationpoint commented on May 26, 2024

I also made it so that you can vary the hue in addition to the lightness, so you can have shades of nearby colors in addition to the color you want:
out

Dunno if that's useful but it was an easy addition to make.

from ck2plus_rewrite.

schwarherz avatar schwarherz commented on May 26, 2024

@questionmarkexclamationpoint If you're going to put the script itself somewhere I'd prefer if it gets put in the Assets repo so we don't end up with clutter in the main repo like happened with the old.

from ck2plus_rewrite.

questionmarkexclamationpoint avatar questionmarkexclamationpoint commented on May 26, 2024

Okie doke!

from ck2plus_rewrite.

 avatar commented on May 26, 2024

Lets do this now.

from ck2plus_rewrite.

 avatar commented on May 26, 2024

20200103003841_1

from ck2plus_rewrite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.