Giter VIP home page Giter VIP logo

Comments (7)

schwarherz avatar schwarherz commented on May 27, 2024

Complete per Assignee

from ck2plus_rewrite.

LordPeter avatar LordPeter commented on May 27, 2024

Still missing some events to make certain ambitions behave as expected (particularly "find a friend").
Should be pretty easy to do though.

from ck2plus_rewrite.

Whizzer avatar Whizzer commented on May 27, 2024

Please note that vanilla, as of Holy Fury, has a 'Make a Friend'-ambition already.

from ck2plus_rewrite.

LordPeter avatar LordPeter commented on May 27, 2024

Oh! Then we can scrap that... but then we will still need to take a look because that ambition was added to the mod already.

from ck2plus_rewrite.

Whizzer avatar Whizzer commented on May 27, 2024

Each line should probably be checked. As it stands, Validator reports quite the list of issues, several related to old Plus features we don't currently have implemented.

from ck2plus_rewrite.

schwarherz avatar schwarherz commented on May 27, 2024

@ck2plus/developers Does anyone know the status of this? Can it be closed?

from ck2plus_rewrite.

LordPeter avatar LordPeter commented on May 27, 2024

Nope, not done.
Assignee has not been active recently, and iirc at least one ambition from old Plus still had to be ported.
And then there's the validator issues Whizzer mentioned above, since it was probably a copy&paste from old Plus thus far - these issues are likely still remaining.
We need someone to take a look at this.

from ck2plus_rewrite.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.