Comments (5)
Do we actually want this? I've put the query in the code commented out, but it seems kinda... useless?
If you think otherwise you just need to uncomment the code and then throw on some extra text in the conditional. I also think it might be slow query...
from pyburlybot.
Not a big deal if it's a slow query since it'll just be on tell, but I agree that it seems kinda useless.
The message existed in oldbbm because oldbbm did fire and forget with the tells when pastebinning them, so it would be better to focus our attention on ensuring the delivery of tells instead of warning that they might get lost.
from pyburlybot.
This may be important after all since current bot will fire and forget pastehelper.
Do we want to continue using pastebins for tells and stuff? Or do we want overflows to go to notices and such? (I think people like spying on tells and stuff. I know I do if I'm bored.)
from pyburlybot.
I'm thinking the best bet is to modify the database to indicate delivery after either bot.say()
or pastehelper()
finishes successfully; I'm giving this a try in pbm_alert.py
and will implement in tell if it's coo'.
from pyburlybot.
That would be useful to rewire the logic to update the DB after paste finishes.
I update the DB in the same request as getting the tells (batch) so that no weird timing double tell issues occur but maybe that can be reworked, or undoing the update on failure.
https://github.com/Clam-/pyBurlyBot/blob/master/modules/pbm_tell.py#L105
from pyburlybot.
Related Issues (20)
- [dispatcher] Thread timeouts HOT 1
- [modules] What to do about module names HOT 6
- [core] Investigate if SIGTERM is correctly handled i.e. REBOOT HOT 6
- [alias] Removing alias with space attempts to remove from group
- [dispatcher] Allow eventtype to be numeric or symbolic for ease-of-use HOT 2
- [simplecommands] hiding from .help
- [container] send_and_wait safety considerations HOT 1
- [alert] Should only be able to alert self
- [time] Doesn't support look ups based on standard time zones
- [help] Add docstring help to butt/butts commands
- [Alias] Finish alias grouping HOT 3
- [Alias] BBM sometimes 2blind HOT 1
- [Watch2Gether] HOT 1
- [tell/remind] Old entries stored in database HOT 1
- [alert/timer/client] SignedOn unsafe for admin_reload HOT 1
- [random] Various additional functionality HOT 2
- [timer] Something hapen HOT 1
- [alert/alias] Exception when adding new alias which is an existing user HOT 1
- wikipedia 1.4.0 suggestion override issue
- AWS EC2 instance management module
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pyburlybot.