🐞 PHP deprecation when saving general options about classicpress-v2 HOT 11 CLOSED

I did some more tests and get weird results also with WP (WSOD).
What about this little change?

$value = preg_replace( '/[^0-9:.-]/', '', $value ); // Strips slashes.

$value = preg_replace( '/[^0-9:.-]/', '', $value ?? '' ); // Strips slashes.

Or we have to dig a little more?

from classicpress-v2.

If you empty the database or re-install to a fresh set of tables do you still see this issue?

In your database what is the gmt_offset option value? ( SELECT * FROM cp_optionsWHEREoption_name = 'gmt_offset';) if you have a Timezone selected and if you have an offset selected?

from classicpress-v2.

gmt_offset is correct in the option table and in the page too (I'm choosing "Rome" and not the offset).

Same after a fresh install.

from classicpress-v2.

Why you say gmt_offset is correct in the option table - is that a number? When I set for "Rome" the got_offset value in the table is empty. Any plugins or Timezone code in the Theme?

from classicpress-v2.

With Rome I have gmt_offset = 2.
Tested with ClassicPress TwentySixteen and ClassicPress TwentySeventeen themes.

from classicpress-v2.

Well, here we seem to have a difference.

With Timezone set as Fiji, in my database I have:

With Timezone set as Rome, I have:

And with Timezone set as UTF_8, I have:

So, it seems for some reason when you set the Timezone as a place that the got_offset value is not being cleared out. Are you using caching locally at all?

from classicpress-v2.

I was using wp-cli to get gmt_offset, my fault.
The value in the database is as in your, but it's filtered by wp_timezone_override_offset() defined in src/wp-includes/functions.php and hooked in src/wp-includes/default-filters.php.
Hope this helps.

from classicpress-v2.

Looking here:

			$value  = null;
			if ( isset( $_POST[ $option ] ) ) {
				$value = $_POST[ $option ];
				if ( ! is_array( $value ) ) {
					$value = trim( $value );
				}
				$value = wp_unslash( $value );
			}
			update_option( $option, $value );

gmt_offset is not in $_POST, so why updating gmt_offset to null?
In general, why updating an option that is not required to update?

from classicpress-v2.

Found ticket for this:
https://core.trac.wordpress.org/ticket/57728

from classicpress-v2.

Good job finding the upstream ticket. They have a patch, we can monitor now to see when it is merged.

from classicpress-v2.

Fixed in #88

from classicpress-v2.