Giter VIP home page Giter VIP logo

Comments (5)

mattyrob avatar mattyrob commented on June 12, 2024 1

I made a backport with the script we have a pushed the branch, but it got pushed to core! So, I ave a applied some protections to the develop branch in the hope that doesn't happen again.

from classicpress-v2.

mattyrob avatar mattyrob commented on June 12, 2024

I honestly don't know the answer here, it seems like this file was never in ClassicPress 1.x.x.

The build process in Gruntfile, creates and gz compresses the file and then deletes the original. I can only presume to save download side as the gz compressed file is available. It was also previously listed as a file that should be removed on update.

We can amend the build process so this file included but it is about 0.5meg in size and it's absence hasn't caused issues until now. Is Elementor calling this file directly and expecting it to be there? Why isn't is calling the gz version as a preference?

from classicpress-v2.

mattyrob avatar mattyrob commented on June 12, 2024

I found this ticket upstream. It seems like a rational and reasonable change to backport and we can drop the wp-tinymce.js.gz file creation and inclusion.

from classicpress-v2.

viktorix avatar viktorix commented on June 12, 2024

@mattyrob thanks for looking into it. I guess this wasn't forked since we applied changes to v1 files?

from classicpress-v2.

mattyrob avatar mattyrob commented on June 12, 2024

This issue appears to now be fixed in the nightly:

https://github.com/ClassyBot/ClassicPress-v2-nightly/tree/develop/wp-includes/js/tinymce

from classicpress-v2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.