Giter VIP home page Giter VIP logo

Comments (5)

mattyrob avatar mattyrob commented on June 12, 2024

Is it worth adding these to PR #57 or should we have a separate PR?

from classicpress-v2.

mattyrob avatar mattyrob commented on June 12, 2024

I've created a new branch that should address a lot of the list above and also some things I noted on a fresh install.

I have not yet created a PR, would suggest a check over the branch and maybe discuss the items above at a weekly meeting first.

from classicpress-v2.

viktorix avatar viktorix commented on June 12, 2024

@mattyrob thanks for working on this. I checked off items in this issue that your branch fixed.

One question:

  • For the version number, should we display what WP version current CP version is based on? Right now, it shows Version: 2.0.0+nightly.20230518 (Latest version: 2.0.0+nightly.20230523). Or maybe create a new row, WP Version:.

from classicpress-v2.

mattyrob avatar mattyrob commented on June 12, 2024

I thought I'd addressed the clipboard issues as well and the checksums problem may well be addressed already in #79

As for the version, it is pulled from the current $cp_version from wp-includes/version.php. $wp_verision can be reported easily enough. We should avoid an API call here in my opinion as it duplicates information already available on the update page in admin.

from classicpress-v2.

viktorix avatar viktorix commented on June 12, 2024
  • If we can include $wp_version that would be great, but I'm also OK with leaving it out. Whatever you think is best.
  • For clipboard, one other item that we should consider changing is the section headings in the copied data. Such as wp-core and wp-paths-sizes. We should change it to cp-core, etc. to make sure there's no confusion.
  • I will wait for #79 to merge and then will check checksums issue.
  • The last thing, I think, is the hosting team wording. I would change "ClassicPress Hosting Team" to simply "ClassicPress" and the "in the team handbook" to "in the server requirements." since we don't have handbooks. I assume we can change the URL via gettext() method. I will need to create that page in the docs.

from classicpress-v2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.