Giter VIP home page Giter VIP logo

Comments (6)

viktorix avatar viktorix commented on May 29, 2024 1

Thanks @smileBeda for pointing this out. It's a good reminder to re-visit plugin header requirements. Haven't looked at this page in a while. With the upcoming v2 based on WP 6.2, this may need to be adjusted further to accommodate that.

We do have a directory requirements, which relate to plugin header requirements:
https://docs.classicpress.net/plugin-guidelines/directory-requirements/

from documentation-issue-tracker.

viktorix avatar viktorix commented on May 29, 2024 1

it will supposedly not require WP 4.9 max anymore, right?

That's correct. $wp_version is set to 6.2.

it will actually mean it needs blocks code available

That's also correct. This is why we've added block compatibility mode to prevent block functions and some classes in themes/plugins from causing fatal errors. Some classes we were not able to polyfill, but they are used by plugins that add/modify blocks so they should not be used by CP users at all. For example, Spectra plugin.

We've also disabled FSE themes from being installed in CP v2.0.

I've been using v2 in production (I like to live dangerously) and so far, I've been able to use plugins that did not work in v1.x, such as Gravity Forms, SEOpress Free/Pro, and Pretty Links Free/Pro.

from documentation-issue-tracker.

smileBeda avatar smileBeda commented on May 29, 2024

I think as long CP ignores the Requires at least: if Requires CP is set, then this would be OK!
It would allow the plugin to both support a higher WP Version, and a CP version of choice.

It might sound weird, but indeed it is entirely possible to (example) produce a plugin with a Block (thus requiring WP 4.9+) and if CP is detected, simply not add that Block and instead provide a fallback solution. Not that this happens often, but, I am rewriting the https://github.com/TukuToi/better-wp-plugin-boilerplate completely to a more modern codebase, and would like to keep it WP and CP compatible. So this came up. I will use Requires CP in the header and make some tests once I have a first working version.

from documentation-issue-tracker.

viktorix avatar viktorix commented on May 29, 2024

@smileBeda make sure it's compatible with v2+. Once we release 2.0, support for 1.x will be stopped soon.

@xxsimoxx might be able to add more information about this, but he might reply after August 21 when he returns from a holiday.

from documentation-issue-tracker.

xxsimoxx avatar xxsimoxx commented on May 29, 2024

I agree with this, but I think it's not yet time to discard Requires at least: header.

  • There are a lot of checks for that value in the code
  • We get many plugins from WordPress directory

from documentation-issue-tracker.

smileBeda avatar smileBeda commented on May 29, 2024

Just out of curiosity - as CP is going 2.0 and will be a copy of some 6.+ WP (without blocks), it will supposedly not require WP 4.9 max anymore, right?
But, then, if a plugin says "min version required 6+", it will actually mean it needs blocks code available.
That then however won't work still on CP as it won't have blocks code available.

So - if I understand it right - if CP indeed is listening to that directive inside its own code, this would have to be removed prior to any 2.0 release, because it would otherwise effectively "allow" install of plugins requiring 6+ from the repo, and still fail to run those plugins (if they include blocks, which is highly expected)?

However, also note that the Requires at least: is supposedly only used by the WP Repo and its API, not by the actual source code of WP (meaning, if you upload the plugin manually, it should actually not check that directive). But I could be wrong about that, it has been a while that I checked how it works.

from documentation-issue-tracker.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.