Giter VIP home page Giter VIP logo

Comments (7)

akiko-pusu avatar akiko-pusu commented on June 10, 2024 2

Hi, I could reproduce this issue and made tiny workaround considering above comment.
I don't know if this patch is effective with other database (such as MySQL, MariaDB and production env).

diff --git a/init.rb b/init.rb
index cc88405..f651997 100644
--- a/init.rb
+++ b/init.rb
@@ -2,6 +2,7 @@ require_dependency "full_text_search/hooks/search_index_options_content_bottom_h
 require_dependency "full_text_search/hooks/issues_show_description_bottom_hook"
 require_dependency "full_text_search/hooks/similar_issues_helper"
 require "full_text_search/searcher"
+require_dependency "full_text_search/hooks/search_helper"
 
 Redmine::Plugin.register :full_text_search do
   name 'Full Text Search plugin'
@@ -31,5 +32,4 @@ Rails.configuration.to_prepare do
   Journal.include(FullTextSearch::SimilarSearcher::Model)
   SearchHelper.prepend(FullTextSearch::Hooks::SearchHelper)
   SearchController.prepend(FullTextSearch::Hooks::ControllerSearchIndex)
-  IssuesHelper.include(FullTextSearch::Hooks::SimilarIssuesHelper)
 end
diff --git a/lib/full_text_search/hooks/similar_issues_helper.rb b/lib/full_text_search/hooks/similar_issues_helper.rb
index ac7d729..b8ce0d6 100644
--- a/lib/full_text_search/hooks/similar_issues_helper.rb
+++ b/lib/full_text_search/hooks/similar_issues_helper.rb
@@ -22,3 +22,4 @@ module FullTextSearch
     end
   end
 end
+IssuesHelper.prepend(FullTextSearch::Hooks::SimilarIssuesHelper)

If above patch is applied IssuesHelper's ancestors and methods are following:

irb(main):004:0* IssuesHelper.ancestors
=> [FullTextSearch::Hooks::SimilarIssuesHelper, FullTextSearch::Hooks::SettingsHelper, IssuesHelper, Redmine::Export::PDF::IssuesPdfHelper, ApplicationHelper, Redmine::Helpers::URL, Redmine::Hook::Helper, Redmine::Themes::Helper, Redmine::SudoMode::Helper, Redmine::Pagination::Helper, GravatarHelper::PublicMethods, Redmine::I18n, Redmine::WikiFormatting::Macros::Definitions]

irb(main):005:0> IssuesHelper.instance_methods
=> [:render_similar_issues, :display_score?, :render_issue_tooltip, :issue_list, :grouped_issue_list, :issue_heading, :render_issue_subject_with_tree, :render_descendants_tree, :render_issue_relations, :issue_estimated_hours_details, :issue_spent_hours_details, :bulk_edit_error_messages, 

.... snip ...

It seems forum messages and comments against news article are not searched correctly.
(Sorry I don't know much about this plugin's feature...)

Hope any help.

Env info

1 vagrant@ubuntu-xenial:~/work/redmine-3.4.6⟫ bin/rake about
About your application's environment
Rails version             4.2.8
Ruby version              2.3.1-p112 (x86_64-linux-gnu)
RubyGems version          2.5.2.1
Rack version              1.6.10
Middleware                Rack::Sendfile, Rack::ContentLength, ActionDispatch::Static, Rack::Lock, #<ActiveSupport::Cache::Strategy::LocalCache::Middleware:0x0000000456b3b0>, Rack::Runtime, Rack::MethodOverride, ActionDispatch::RequestId, Rails::Rack::Logger, ActionDispatch::ShowExceptions, ActionDispatch::DebugExceptions, ActionDispatch::RemoteIp, ActionDispatch::Callbacks, ActiveRecord::ConnectionAdapters::ConnectionManagement, ActiveRecord::QueryCache, ActionDispatch::Cookies, ActionDispatch::Session::CookieStore, ActionDispatch::Flash, ActionDispatch::ParamsParser, ActionDispatch::XmlParamsParser, Rack::Head, Rack::ConditionalGet, Rack::ETag, RequestStore::Middleware, OpenIdAuthentication
Application root          /home/vagrant/work/redmine-3.4.6
Environment               production
Database adapter          postgresql
Database schema version   20170810052427

from redmine_full_text_search.

y503unavailable avatar y503unavailable commented on June 10, 2024 2

@akiko-pusu ありがとうございます。
full text searchと、 https://github.com/ixti/redmine_tags を同居させると、
チケット作成/表示時に 同じく display_score? でエラー発生していましたが、
上記パッチにて解消しました。

CENTOS7 mariadb
bundle exec rake about RAILS_ENV=production
About your application's environment
Rails version 4.2.8
Ruby version 2.4.4-p296 (x86_64-linux)
RubyGems version 2.6.14.1
Rack version 1.6.10
Middleware Rack::Sendfile, Rack::ContentLength, ActionDispatch::Static, Rack::Lock, #ActiveSupport::Cache::Strategy::LocalCache::Middleware:0x000056315f9b5528, Rack::Runtime, Rack::MethodOverride, ActionDispatch::RequestId, Rails::Rack::Logger, ActionDispatch::ShowExceptions, ActionDispatch::DebugExceptions, ActionDispatch::RemoteIp, ActionDispatch::Callbacks, ActiveRecord::ConnectionAdapters::ConnectionManagement, ActiveRecord::QueryCache, ActionDispatch::Cookies, ActionDispatch::Session::CookieStore, ActionDispatch::Flash, ActionDispatch::ParamsParser, ActionDispatch::XmlParamsParser, Rack::Head, Rack::ConditionalGet, Rack::ETag, RequestStore::Middleware, OpenIdAuthentication
Application root /var/lib/redmine
Environment production
Database adapter mysql2
Database schema version 20180122193833

from redmine_full_text_search.

akiko-pusu avatar akiko-pusu commented on June 10, 2024 1

@yassan こんにちは。
昨年、このエラーメッセージに近い状況が発生したので、何かのお役にたてればと思ってリンクさせていただきます。

Ref. two-pack/redmine_xlsx_format_issue_exporter#50

上記の場合は、redmine_xlsx_format_issue_exporter というプラグインと、full_text_searchの双方でIssuesControllerに対するバッチを当てており、後から読み込まれたredmine_xlsx_format_issue_exporter のほうが勝ってしまい、full_text_searchで定義したメソッドが無い、という症状が出ていました。

同居しているプラグインで、redmineのコントローラに対してパッチを当てているもの(IssuesControllerあたり)について、該当するものがないか、あればそれだけ取り外してどうなるか、というのも確認につながるかなと思います。

from redmine_full_text_search.

iquiw avatar iquiw commented on June 10, 2024 1

I previously got the same error with redmine_persist_wfmt (#36 (comment)).

I am no longer using redmine_persist_wfmt as redmine_full_text_search is more valuable to me.

from redmine_full_text_search.

yassan avatar yassan commented on June 10, 2024 1

@iquiw Thank you, good information 👍 So, It was the same case...
But, I want to use redmine_persist_wfmt( https://github.com/pinzolo/redmine_persist_wfmt/ ).

@akiko-pusu 情報ありがとうございます。そんな挙動もあるんですね。とても参考になりました。上にも書いてますが、プラグイン外したら、チケット作成出来るようになったので同じ原因のようです。

redmine_persist_wfmt - issues_controller_patch.rb#L21

from redmine_full_text_search.

akiko-pusu avatar akiko-pusu commented on June 10, 2024 1

@yassan
I found the related issue at redmine.org and commented.
Ref. https://www.redmine.org/issues/28133

from redmine_full_text_search.

yassan avatar yassan commented on June 10, 2024 1

こちらの環境でも上記の対応で動作を確認しました。

from redmine_full_text_search.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.