Giter VIP home page Giter VIP logo

Comments (4)

ZhilkinSerg avatar ZhilkinSerg commented on June 9, 2024

We already have quick shortcuts in Android builds and it should not take much to get them working on desktop (WIP is here - https://github.com/CleverRaven/Cataclysm-DDA/compare/master...ZhilkinSerg:Cataclysm-DDA:ui-quick-shortcuts?expand=1). Displaying icons in addition to keys in quick shortcuts should be rather easy too.

The issue is if you press ? on a main game screen with the following patch you will see that there are too many commands (144 in total, 80 of which are bound to a key). There is probably no way all icons for them would fit on a screen without obscuring much of the map.

image

@ -646,6 +646,15 @@ keybindings_ui::keybindings_ui( bool permit_execute_action,
    legend.push_back( colorize( _( "Keybinding active only on this screen" ), local_key ) );
    legend.push_back( colorize( _( "Keybinding active globally" ), global_key ) );
    legend.push_back( colorize( _( "* User customized" ), global_key ) );
    int bound_actions_count = 0;
    for( const std::string &a : parent->get_registered_actions() ) {
        auto iel = parent->keys_bound_to( a );
        if( iel.size() > 0 ) {
            bound_actions_count++;
        }
    }
    legend.push_back( string_format( _( "All commands: %d, Bound to a key: %d" ),
                                     parent->get_registered_actions().size(), bound_actions_count ) );
    if( permit_execute_action ) {
        legend.push_back( string_format(
                              _( "Press %c to execute action\n" ),

from cataclysm-dda.

Procyonae avatar Procyonae commented on June 9, 2024

Personally I'd prefer this added as an accessibility option that can default on for new players rather than a compulsory thing, personally I'd have no interest using it and I imagine the same goes for alot of peeps who've played alot and I'd rather not lost screen space for something I'm never going to interact with. You literally said as much, I can't read >_<

from cataclysm-dda.

Qrox avatar Qrox commented on June 9, 2024

Maybe we can show a menu when you right-click on your character/nearby terrain to list the action you can do (similar to the current action menu). It won't take any screen space until requested, and adding icons to the menu should be easy.

from cataclysm-dda.

Daikiero avatar Daikiero commented on June 9, 2024

We already have quick shortcuts in Android builds and it should not take much to get them working on desktop (WIP is here - https://github.com/CleverRaven/Cataclysm-DDA/compare/master...ZhilkinSerg:Cataclysm-DDA:ui-quick-shortcuts?expand=1). Displaying icons in addition to keys in quick shortcuts should be rather easy too.

The issue is if you press ? on a main game screen with the following patch you will see that there are too many commands (144 in total, 80 of which are bound to a key). There is probably no way all icons for them would fit on a screen without obscuring much of the map.

image

@ -646,6 +646,15 @@ keybindings_ui::keybindings_ui( bool permit_execute_action,

    legend.push_back( colorize( _( "Keybinding active only on this screen" ), local_key ) );

    legend.push_back( colorize( _( "Keybinding active globally" ), global_key ) );

    legend.push_back( colorize( _( "* User customized" ), global_key ) );

    int bound_actions_count = 0;

    for( const std::string &a : parent->get_registered_actions() ) {

        auto iel = parent->keys_bound_to( a );

        if( iel.size() > 0 ) {

            bound_actions_count++;

        }

    }

    legend.push_back( string_format( _( "All commands: %d, Bound to a key: %d" ),

                                     parent->get_registered_actions().size(), bound_actions_count ) );

    if( permit_execute_action ) {

        legend.push_back( string_format(

                              _( "Press %c to execute action\n" ),

This is where the right-click context menu option comes in. CDDA has a ton of keybinds that aren't used commonly ("look at the sky", anyone?) and I feel that those bindings would be perfect for a drop down menu, rather than having a dedicated icon for every single keybind in the game.

from cataclysm-dda.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.