Begin enforcing the new ``to-hit`` syntax about cataclysm-dda HOT 6 OPEN

Oh I am changing the C++ default, my point is that because it's currently defaulting to 0 there are melee weapons without a to_hit defined that are going to be heavily invisibly nerfed so I'm trying to make a test to detect them so I can manually add to_hit s to them at the same time (the fire axe didn't have a to_hit defined for instance and is still an early weapon of choice afaik so that would've annoyed some peeps ;D)

from cataclysm-dda.

Very cool. Glad to see it's gonna be used more.

from cataclysm-dda.

Got the test working I'm just doing a second 1 off test to find all in repo melee weapons that don't have a to_hit (old or new inc inherited) defined bc while the default is supposed to be -2 it's actually 0 rn so they'll want defining at the same time.

from cataclysm-dda.

Shouldn't we add that on c++ side so that we don't need json churn for things that absolutely don't need it

from cataclysm-dda.

Shouldn't add what?

from cataclysm-dda.

The value defaulting to -2.

from cataclysm-dda.