Certificate should contain "push" keyword about apns-http2 HOT 9 OPEN

That's not the point. All sensitive information is masked out. Why the strings are hardcoded ?

` if (!cn.toLowerCase().contains("push")) {
throw new CertificateException("Not a push certificate - " + cn);
}

    if (production && cn.toLowerCase().contains("apple development ios push services")) {
        throw new CertificateEnvironmentMismatchException("Invalid environment for this certificate");
    } else if (!production && cn.toLowerCase().contains("apple production ios push services")) {
        throw new CertificateEnvironmentMismatchException("Invalid environment for this certificate");
    }

`

The certs need not contain the strings that are hardcoded in the cert validation which is being done.

from apns-http2.

from apns-http2.

CN is like this: CN=APSP:0226d278-d925-4044-af07-a346da05e2c5/C=IN

As you can see this doesn't contain any strings against which validation is being done. For example: "push", "apple development ios push services","apple production ios push services". Please let us know what we can do to get this working. Would be a great help!!

from apns-http2.

@rohitsahay2000 Until now, all the certificates issued by Apple have contained those strings. It validates the certificate and ensures that you don't accidentally try to use your developer certificate (which has happened many times in the past).

I'll issue a new certificate for APNs tomorrow and check the CN on it.

from apns-http2.

@judepereira : Did you check? Have we removed the hardcoding?

from apns-http2.

any update on this?

I just downloaded a production certificate and it has CN=Apple Development IOS Push Services: myBunldleId

I doubled checked. It is the production certificate and it has development in it.

from apns-http2.

java.security.cert.CertificateException: Not a push certificate - VoIP Services: com.test.app
	at com.clevertap.apns.CertificateUtils.validateCertificate(CertificateUtils.java:135)
	at com.clevertap.apns.clients.SyncOkHttpApnsClient.<init>(SyncOkHttpApnsClient.java:131)
	at com.clevertap.apns.clients.AsyncOkHttpApnsClient.<init>(AsyncOkHttpApnsClient.java:72)
	at com.clevertap.apns.clients.ApnsClientBuilder.build(ApnsClientBuilder.java:170)

VoIP Push certification not working...

from apns-http2.

hi
I am facing with is bug
how to slove it?

from apns-http2.

It would be great to be able to change behavior with some boolean flag. (include verifying or not)

from apns-http2.