Comments (1)
Noting that this seems to be due to a bug in the NYC Geosearch API. For example, the response to this query still returns the address in Brooklyn as the first result (see the features
array in the response object):
https://geosearch.planninglabs.nyc/v1/search?text=52%20HENRY%20STREET,%20Manhattan
Currently the AIRS frontend app grabs the first result from the search/
API endpoint response which is why the incorrect address is displayed.
Until the NYC Planning Labs team fixes this problem in the API a work around could be storing the lat, lon, and BBL for the selected address from the autosuggest results list (this is what is returned by the Geosearch API autocomplete
endpoint once a user starts typing in the search box) when a user chooses an address from that list. This would require some additional branching logic that handles someone typing an address but not choosing an autosuggest result then hitting submit vs. someone selecting an autosuggest result and then hitting submit. The former scenario would still require the address text being passed to the Geosearch search/
endpoint while the latter would not. The existing implementation passes the address text to the search
endpoint no matter what, because well I was lazy.
from am-i-rent-stabilized.
Related Issues (20)
- Critical Bug: Geocoding service needs to be updated
- Add missing translations for ARIA attributes & image alt text
- Improve a11y of address search form on slide 2 HOT 1
- Use native <dialog> HTML element for all modals
- Improve a11y of language toggle buttons
- Bug: typing in an address on iOS prevents form submit HOT 2
- Manage focus when scrolling between slides HOT 1
- Fix tab index so that the user can't jump between slides by tabbing HOT 1
- Use HTML button element for buttons on home page
- Add 404 page
- upgrade or remove normalize.css
- Add link to KoFi profile HOT 1
- RFP: Replace Handlebars with vanilla HTML and a localization JS library
- clean up misc subdirectories in root of repo HOT 1
- add code of conduct
- use updated likely rent stabilized data
- Fix use of headings through out HOT 1
- Feature: URI query param that sets app's language on load
- Dev Task: Bump NodeJS version
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from am-i-rent-stabilized.