Giter VIP home page Giter VIP logo

Comments (2)

climu avatar climu commented on July 29, 2024

Thanks for spotting that. Actually the issue is more of an undocumented and unused feature:

One league is called primary. There is a button in league admin tools to set it:
image

The url /league/ will always direct to the primary league.

So the issue here is the primary league have not been updated for ages.

Mind that the name is quite confusing since it also refer to primary leagues where player are automatically enrolled.
image

I think a better fix would be to control the url /league/. I see 2 ways:

  1. always redirect it to /ladder/
  2. Admins should update the One primary league everymonth.

I guess 1 is better.

Change would happen here:

openstudyroom/league/views.py

Lines 263 to 264 in 0ae71e9

if event_id is None:
event = Registry.get_primary_event()

with much inspiration from:

openstudyroom/league/views.py

Lines 307 to 317 in 0ae71e9

def ladder(request):
"""A simple view that redirects to the last open ladder league."""
league = LeagueEvent.objects.filter(
event_type='ladder',
is_open=True,
community__isnull=True
).order_by('end_time').first()
return HttpResponseRedirect(reverse(
'league:results',
kwargs={'event_id': league.pk})
)

from openstudyroom.

angelsesma avatar angelsesma commented on July 29, 2024

thanks for the heads up! will give it a shot :)

from openstudyroom.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.