Comments (2)
NKjoep
commented on May 22, 2024
I forgot to link the experiment I mentioned: https://github.com/NKjoep/hn-meets-modern-html
from hackernews-react-graphql.
clintonwoo
commented on May 22, 2024
Hey thanks for getting in touch. Looks like you've done a nice job with the HTML! I starred your repo, well deserved. It's true the original HN HTML is quite badly structured and makes little to no sense today.
This project is mostly a direct copy of HN with all the functionality provided by the web API (which is a lot but not everything) but the website has a large number of pages. It looks like your HTML is fairly close but the header is different on Mobile and it seems like you haven't reconstructed the whole website. There would likely be some html errors with React components (which can be pages too) expecting to be in a table if the site is only partially converted.
To me it only makes sense to change the HTML if the whole project does it (or at least every page that uses the Main layout). It would be a lot of work to change and maintain especially if something changes in the future (Some data may become available in the HN API or we rebuild it in the clone). I guess that there may be 20 files to change even before future maintenance is required.
What do you think about what I have to say?
from hackernews-react-graphql.
Related Issues (20)
- localhost:3000 does not work
- `npm install` fails in fresh clone HOT 6
- Video Series/ Step by step tutorial
- Making presentational components functional HOT 1
- Removing inline styling HOT 2
- Live Demo link is broken HOT 1
- freeze when docker build --tag 'clintonwoo/hackernews-react-graphql:latest' --rm . HOT 1
- Freeze When i use this command npm run build && npm start command not working HOT 1
- npm ERR! missing script: dev HOT 3
- Standardize test location? HOT 1
- Use a real database HOT 1
- Changing default port to 8080 HOT 1
- Bind log to console HOT 1
- Wrong filename for spec of CommentService HOT 1
- Failed when run test script HOT 1
- Failed to run the app locally HOT 3
- Live Demo Doesn't Work HOT 1
- wrong mention /react-apollo/getting started HOT 1
- Cannot POST comment on live demo after account creation and login. HOT 1
- question about building(what should I do next to get data) HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hackernews-react-graphql.