Some not-so-good suggestions by kibit about kibit HOT 3 CLOSED

The following two rules are to blame:

(fn ?args (?fun . ?args)) ?fun
(fn* ?args (?fun . ?args)) ?fun

These rules tries to capture patterns like

(map #(inc %) [1 2 3]) => (map inc [1 2 3])

but since the same pattern is used (idiomatically) when wrapping java methods in functions for higher order use the rules, as they are in 0.0.2, are indeed bad. I'll probably remove these rules for now.

What's needed (in a future release) is a declarative way to embed additional constraints, for example

[(fn ?args (?fun . ?args)) ?fun :when (and (symbol? ?fun) (not-interop-form ?fun))]

from kibit.

Right, I even had forgotten that (map .javaMethod objs) is not even valid. ;-) In those cases, maybe (map (memfn javaMethod) objs) would be a bit more idiomatic, but right now there's no support for type hinting memfn (http://dev.clojure.org/jira/browse/CLJ-910).

But what's the cause of the second example of mine? Here, the args do not equal the return value, it's just a part of it.

from kibit.

I commented out the invalid rules in this commit.

from kibit.