Can simplify prewalk instead of postwalk? about kibit HOT 1 CLOSED

We can definitely try prewalk instead. I don't think it'll matter for
the kibit leiningen plugin. Could you send a pull request?

Jonas

On Mon, Mar 26, 2012 at 8:06 AM, Kevin Lynagh
[email protected]
wrote:

Is there a reason why the simplification occurs in postwalk order instead of prewalk order?
If not, I'd prefer prewalk because then I can write rules to match forms based on their innards without worrying about those innards getting mangled by other rules.
This came up for me when trying to replace metadata'd forms with a keyword to mark them for removal:

(defn ^:cljs only-works-on-the-web [x] ...)

should become :remove-me.
Except that I also want to remove individual forms with that metadata:

^:cljs (toplevel-form)

(this case it doesn't matter if you prewalk or postwalk).
In the former case, though, if you postwalk, you end up with

(defn :remove-me [x] ...)

---

Reply to this email directly or view it on GitHub:
#23

from kibit.