.hashCode of ordered maps with nil keys or values NPEs about ordered HOT 5 CLOSED

I've figured out what's going on: .hashCode doesn't work if a key or value is nil.

(.hashCode (ordered-map [[nil nil]]))
;; NullPointerException   flatland.ordered.map.OrderedMap/fn--28038 (map.clj:90)

from ordered.

The bug is on this line: https://github.com/amalloy/ordered/blob/develop/src/flatland/ordered/map.clj#L90

Context:

  (hashCode [this]
    (reduce (fn [acc ^MapEntry e]
              (let [k (.key e), v (.val e)]
                (unchecked-add ^Integer acc ^Integer (bit-xor (.hashCode k) (.hashCode v)))))
0 (.seq this)))

Either (.hashCode k) or (.hashCode v) will raise the exception. Looks like that should be ord with 0 or something. Would you be interested in a PR?

from ordered.

Sure!

from ordered.

Cool, #28 is up.

from ordered.

@arrdem any chance you can expedite cutting a release from #28 ?

from ordered.