Comments (5)
jafingerhut
commented on August 26, 2024
1
Sorry if I am belaboring the obvious, but definitely good to add a test case that compares .hashCode of an ordered set against .hashCode of Clojure's built-in set type, both containing a nil element (and a few other chosen elements) to verify that they are the same with whatever code changes you make.
from ordered.
borkdude
commented on August 26, 2024
Sounds good to me
from ordered.
NoahTheDuke
commented on August 26, 2024
Seems there was an incorrectly written test to check for this very thing. Oops!
from ordered.
borkdude
commented on August 26, 2024
I don't think this issue is fixed since the hashcode for set with nil will be the same as hash-set with false now.
from ordered.
NoahTheDuke
commented on August 26, 2024
Ah dang, right you are.
from ordered.
Related Issues (20)
- What can it be used at? HOT 4
- [1.5.6] Must hint overloaded method: toArray HOT 5
- Interested in transitioning amalloy/ordered to clj-commons? HOT 1
- Can we get this to work on cljs? HOT 7
- ordered/set fails on Java 11 HOT 3
- Ordered pulls in useful
- Is it possible to get the min/max element? HOT 4
- ordered-1.5.8 gives reflection warnings
- data reader depends on imports being available? HOT 20
- Strange rendering at the repl HOT 4
- No changelog updates
- Reader literals assume imports HOT 5
- Make `ordered` auto-deployable
- Remove support for Clojure versions prior to 1.8
- Make `ordered-set` available for cljs
- Associative methods don't work on transient ordered maps HOT 1
- Add ordered set operations?
- Runtime resolve bloats native image size
- CI seems to suffer from bitrot HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ordered.