Moment.js extern is out of date about packages HOT 8 CLOSED

Looks like putting the moment.js through Closure compiler will break it even with proper extern file.

Perhaps it would not be too big work to create cljs.core test going through documented api of Moment.

from packages.

Is this still the case? Haven't we straightened it out with eg cljsjs/moment 2.9.0-0 ? If so, can we close this?

from packages.

The extern is still based on Moment 2.6.0 externs.

At the least the following changes would require changes to the extern file:

2.7.0

• add moment.min and moment.max and deprecate min/max instance methods

(2.8.0

• lang is renamed to locale, langData -> localeData. Also there is now defineLocale that should be used when creating new locales) this is included, I think

2.8.2

• add duration#toString()

2.9.0

• Add firstDayOfWeek, firstDayOfYear locale getters
• add moment.fn.isBetween
• Add moment.isDate method
• Implement toJSON function on Duration
• Implement moment.fn.utcOffset, deprecate momen.fn.zone

It's easy to implement the changes but they would require some, perhaps manual, testing.

from packages.

Ah ok right; when the next version bump happens from moment I will take the opportunity to revisit this.

from packages.

+1 for a fix, would like to include the latest moment.js using cljsjs.

from packages.

Just wanted to use moment.js — but I'll hold off and wait for a fix.

from packages.

@jwr, I think there are quite many people using moment.js already even though the extern is not perfect.

It's probable that the extern won't be improved unless some user creates a PR about this, I'm not using Moment.js myself. Points in my previous comment should still hold and provide a starting point for checking what is broken with the extern.

from packages.

@Deraen thanks. I'll use it, then — and if I hit breakage, I'll try to fix it.

from packages.